Update SDK to match the return of /users/search #117

New Issue

JonasFranz · 2018-12-17T14:22:46Z

JonasFranz commented

2018-12-17 14:22:46 +00:00

Author: @zeripath Posted at: 02.09.2018 12:06

As per issue https://github.com/go-gitea/gitea/issues/4841. The current implementation of the /users/search API does not return a UserList but rather an object similar to the SearchResults object returned by /repos/search. This pull request fixes swagger API so that it actually describes the reality of what is returned.

The issue is that this API has been wrong for at least 10 months - therefore tools may have grown up using the incorrect API. I have also created a pull request for the opposite solution https://github.com/go-gitea/gitea/pull/4846 - which if pulled would mean this request was unnecessary.

Author: @zeripath Posted at: 02.09.2018 12:06 As per issue https://github.com/go-gitea/gitea/issues/4841. The current implementation of the `/users/search` API does not return a UserList but rather an object similar to the SearchResults object returned by `/repos/search`. This pull request fixes swagger API so that it actually describes the reality of what is returned. The issue is that this API has been wrong for at least 10 months - therefore tools may have grown up using the incorrect API. I have also created a pull request for the opposite solution https://github.com/go-gitea/gitea/pull/4846 - which if pulled would mean this request was unnecessary.

JonasFranz added the

lgtm/done

label 2018-12-17 14:22:46 +00:00

Sign in to join this conversation.