ThatHurleyGuy
  • Joined on 2023-01-20
ThatHurleyGuy commented on pull request vikunja/frontend#3061 2023-02-08 04:19:48 +00:00
Fix infinite loop when creating filters

Actually, I take that back. I don't think the isNaN check is related here, although I think you're right there's a subtle bug lurking there. The real issue is the time parsing and how timezones…

ThatHurleyGuy commented on pull request vikunja/frontend#3068 2023-02-07 18:54:51 +00:00
Refresh tasks lists after a task has been updated

Really good catch on the loading spinner. Since I'm hosting it locally and the backend you built is so fast, I never even noticed that :)

A better idea would be to only do this if tasks…

ThatHurleyGuy commented on pull request vikunja/frontend#3061 2023-02-07 18:43:32 +00:00
Fix infinite loop when creating filters

Ah yeah that's a good idea, I can take a stab at changing the isNaN check to something like you suggested here later today

ThatHurleyGuy commented on pull request vikunja/frontend#3061 2023-02-07 18:41:35 +00:00
Fix infinite loop when creating filters

@konrad This happens on every version I tried, including main/HEAD. What timezone did you test it in? Like I mentioned in the PR description, it consistently happens to me with any negative offset…

ThatHurleyGuy created branch hurley-release in ThatHurleyGuy/frontend 2023-02-07 07:36:05 +00:00
ThatHurleyGuy pushed to hurley-release at ThatHurleyGuy/frontend 2023-02-07 07:36:05 +00:00
2144952bf9 Merge branch 'reload-tasks-updates' into hurley-release
d657334b58 Merge branch 'stop-nowrap' into hurley-release
a991f99b06 Merge branch 'fix-loop' into hurley-release
Compare 3 commits »
ThatHurleyGuy created branch stop-nowrap in ThatHurleyGuy/frontend 2023-02-07 07:33:41 +00:00
ThatHurleyGuy pushed to stop-nowrap at ThatHurleyGuy/frontend 2023-02-07 07:33:41 +00:00
6d1aa97c9d Allow for tasks titles to wrap for easier mobile readability
ThatHurleyGuy commented on pull request vikunja/frontend#3068 2023-02-06 08:29:00 +00:00
Refresh tasks lists after a task has been updated

An extra API call isn't ideal, but I would say it's worth the better user experience. Could try to make it smarter and only reload if the updated tasks changed a field that is currently being filtered on (e.g. if the task title is updated and the only active filter is on due date, don't bother reloading), but that seemed like it would be a little overly complicated.

ThatHurleyGuy created pull request vikunja/frontend#3068 2023-02-06 08:25:05 +00:00
Refresh tasks lists after a task has been updated
ThatHurleyGuy created branch reload-tasks-updates in ThatHurleyGuy/frontend 2023-02-06 08:14:40 +00:00
ThatHurleyGuy pushed to reload-tasks-updates at ThatHurleyGuy/frontend 2023-02-06 08:14:40 +00:00
984bad6f38 Refresh tasks lists after a task has been updated
ThatHurleyGuy pushed to main at ThatHurleyGuy/frontend 2023-02-06 07:59:57 +00:00
65b90cbee0 [skip ci] Updated translations via Crowdin
74aac1b245 chore(deps): update dependency @histoire/plugin-screenshot to v0.13.0
ade791ed43 chore(deps): update dependency @types/node to v18.11.19
55b008c67c chore(deps): update dependency rollup to v3.14.0
Compare 4 commits »
ThatHurleyGuy commented on pull request vikunja/frontend#3061 2023-02-05 07:21:10 +00:00
Fix infinite loop when creating filters

@konrad Sorry for the super verbose PR description, wanted to try and give plenty of the debugging info I ran into. Let me know if there's anything else I can help do try and fix this!

ThatHurleyGuy pushed to fix-loop at ThatHurleyGuy/frontend 2023-02-05 07:19:15 +00:00
7e532ab680 Prepare date as ISO date to prevent timezone infinite loop
1f088cca18 [skip ci] Updated translations via Crowdin
6fad1e4969 fix(deps): update dependency axios to v1.3.2
eaeddda4e4 feat: improve naming and styles
7cbf0acac5 fix: always show update popup on top
Compare 26 commits »
ThatHurleyGuy pushed to main at ThatHurleyGuy/frontend 2023-02-05 07:18:54 +00:00
1f088cca18 [skip ci] Updated translations via Crowdin
6fad1e4969 fix(deps): update dependency axios to v1.3.2
eaeddda4e4 feat: improve naming and styles
7cbf0acac5 fix: always show update popup on top
3db5ea45d7 feat: move update from navigation to app
Compare 96 commits »
ThatHurleyGuy created pull request vikunja/frontend#3061 2023-02-05 07:17:34 +00:00
Fix infinite loop when creating filters
ThatHurleyGuy pushed to fix-loop at ThatHurleyGuy/frontend 2023-02-05 06:54:53 +00:00
8ea821667b Prepare date as ISO date to prevent timezone infinite loop
ThatHurleyGuy created branch fix-loop in ThatHurleyGuy/frontend 2023-02-05 06:53:34 +00:00
ThatHurleyGuy pushed to fix-loop at ThatHurleyGuy/frontend 2023-02-05 06:53:34 +00:00
d6cdc421b5 Prepare date as ISO date to prevent timezone infinite loop
7d3d1c7c12 Allow for tasks titles to wrap for easier mobile readability
d83ba0c158 fix(deps): update dependency pinia to v2.0.30 (#3042)
cea31d1da7 fix(docker): cross compilation with buildx
12509a7e0f fix(deps): update sentry-javascript monorepo to v7.35.0 (#3041)
Compare 10 commits »