WofWca

WofWca commented on pull request vikunja/frontend#3179

2023-02-28 15:13:00 +00:00

perf: import some modules dynamically

adds an additional request

Does it? I think the build script should be smart enough to not include the same module twice.

we already load the messages in main.ts.

Then we could maybe…

WofWca commented on pull request vikunja/frontend#3179

2023-02-28 15:08:39 +00:00

perf: import some modules dynamically

Below, where it's used?

I think this makes sense, since it's all just about putting the imports at the top.

try catch block

I don't think it's worth it. Default is not always the only…

WofWca commented on pull request vikunja/frontend#3179

2023-02-28 11:02:01 +00:00

perf: import some modules dynamically

Because it would pause the execution of the rest of the function.

WofWca commented on pull request vikunja/frontend#3179

2023-02-28 11:01:34 +00:00

perf: import some modules dynamically

Where do I access .default then? Below, where it's used?

WofWca commented on pull request vikunja/frontend#3179

2023-02-28 10:08:16 +00:00

perf: import some modules dynamically

Please see if the new change is ok.

WofWca pushed to dynamic-import at WofWca/frontend

2023-02-28 10:07:50 +00:00

ba8ab6a4bb refactor: put dynamic imports at the top of the file

WofWca commented on pull request vikunja/frontend#3179

2023-02-28 09:57:55 +00:00

perf: import some modules dynamically

Nope, I didn't do any tests. I'm just hoping to start a mainstream.

WofWca created pull request vikunja/frontend#3179

2023-02-28 09:46:09 +00:00

perf: import some modules dynamically

WofWca created branch dynamic-import in WofWca/frontend

2023-02-28 09:41:27 +00:00

WofWca pushed to dynamic-import at WofWca/frontend

2023-02-28 09:41:27 +00:00

5bf81d016f perf: import some modules dynamically

WofWca created repository WofWca/frontend

2023-02-28 09:37:06 +00:00

WofWca commented on issue vikunja/frontend#3172

2023-02-27 15:03:25 +00:00

500 when get issue

I'm afraid it's not ok to put buttons inside <as.

WofWca opened issue vikunja/frontend#3172

2023-02-27 11:56:02 +00:00

style(list): highlighted area of items is not entirely clickable