fix: remove attachment by id (#725)

Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Reviewed-on: vikunja/frontend#725
Co-authored-by: dpschen <dpschen@noreply.kolaente.de>
Co-committed-by: dpschen <dpschen@noreply.kolaente.de>

src/helpers/find.ts

@@ -0,0 +1,3 @@
+export function findIndexById(array : [], id : string | number) {
+	return array.findIndex(({id: currentId}) => currentId === id)
+}

src/store/modules/attachments.js

@@ -1,5 +1,7 @@
 import Vue from 'vue'
 
+import {findIndexById} from '@/helpers/find'
+
 export default {
 	namespaced: true,
 	state: () => ({
@@ -15,13 +17,9 @@ export default {
 			state.attachments.push(attachment)
 		},
 		removeById(state, id) {
-			for (const a in state.attachments) {
-				if (state.attachments[a].id === id) {
-					state.attachments.splice(a, 1)
-					console.debug('Remove attachement', id)
-					break
-				}
-			}
+			const attachmentIndex = findIndexById(state.attachments, id)
+			state.attachments.splice(attachmentIndex, 1)
+			console.debug('Remove attachement', id)
 		},
 	},
 }