From 0cd9d43a7c939b58340c909ee0bcadb300edfd57 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 3 Jun 2021 16:27:41 +0200
Subject: [PATCH] Fix showing edit buttons when the user does not have the
 rights to use them

---
 src/components/input/editor.vue    | 6 ++++--
 src/services/abstractService.js    | 3 +--
 src/styles/components/task.scss    | 4 ++++
 src/views/list/views/Kanban.vue    | 2 +-
 src/views/tasks/TaskDetailView.vue | 7 +++++--
 5 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/components/input/editor.vue b/src/components/input/editor.vue
index d016466d3..0334bac6b 100644
--- a/src/components/input/editor.vue
+++ b/src/components/input/editor.vue
@@ -34,11 +34,13 @@
 
 		<p class="has-text-centered has-text-grey is-italic" v-if="isPreviewActive && text === '' && emptyText !== ''">
 			{{ emptyText }}
-			<a @click="toggleEdit">Edit</a>.
+			<template v-if="isEditEnabled">
+				<a @click="toggleEdit">Edit</a>.
+			</template>
 		</p>
 
 		<ul class="actions">
-			<template v-if="hasEditBottom">
+			<template v-if="hasEditBottom && isEditEnabled">
 				<li>
 					<a v-if="!isEditActive" @click="toggleEdit">Edit</a>
 					<a v-else @click="toggleEdit">Done</a>
diff --git a/src/services/abstractService.js b/src/services/abstractService.js
index f08df1aa2..e7501af60 100644
--- a/src/services/abstractService.js
+++ b/src/services/abstractService.js
@@ -129,8 +129,7 @@ export default class AbstractService {
 	 * @param route
 	 * @returns object
 	 */
-	getRouteReplacements(route) {
-		let parameters = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {}
+	getRouteReplacements(route, parameters = {}) {
 		let replace$$1 = {}
 		let pattern = this.getRouteParameterPattern()
 		pattern = new RegExp(pattern instanceof RegExp ? pattern.source : pattern, 'g')
diff --git a/src/styles/components/task.scss b/src/styles/components/task.scss
index 97178c790..a403c37c9 100644
--- a/src/styles/components/task.scss
+++ b/src/styles/components/task.scss
@@ -199,6 +199,10 @@
   }
 }
 
+.link-share-container:not(.has-background) .task-view {
+  background: transparent;
+}
+
 .task-view-container {
   padding-bottom: 1rem;
 
diff --git a/src/views/list/views/Kanban.vue b/src/views/list/views/Kanban.vue
index 056f961cc..59515dec6 100644
--- a/src/views/list/views/Kanban.vue
+++ b/src/views/list/views/Kanban.vue
@@ -31,7 +31,7 @@
 						@focusout="() => saveBucketTitle(bucket.id)"
 						@keydown.enter.prevent.stop="() => saveBucketTitle(bucket.id)"
 						class="title input"
-						contenteditable="true"
+						:contenteditable="canWrite"
 						spellcheck="false">{{ bucket.title }}</h2>
 					<span
 						:class="{'is-max': bucket.tasks.length >= bucket.limit}"
diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index b77e96287..65c7cd2ce 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -509,6 +509,9 @@ export default {
 		this.loadTask()
 	},
 	computed: {
+		currentList() {
+			return this.$store.state[CURRENT_LIST]
+		},
 		parent() {
 			if (!this.task.listId) {
 				return {
@@ -522,11 +525,11 @@ export default {
 			}
 
 			const list = this.$store.getters['namespaces/getListAndNamespaceById'](this.task.listId)
-			this.$store.commit(CURRENT_LIST, list.list)
+			this.$store.commit(CURRENT_LIST, list !== null ? list.list : this.currentList)
 			return list
 		},
 		canWrite() {
-			return this.task && this.task.maxRight && this.task.maxRight > rights.READ
+			return typeof this.task !== 'undefined' && typeof this.task.maxRight !== 'undefined' && this.task.maxRight > rights.READ
 		},
 		updatedSince() {
 			return this.formatDateSince(this.task.updated)