From 15a2da41ba3904843db10e7054c9d99d45087392 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 12 Nov 2020 20:57:39 +0100
Subject: [PATCH] Show loading spinner when loading namespaces & lists

---
 src/components/home/navigation.vue      | 5 +++--
 src/store/modules/namespaces.js         | 6 ++++++
 src/styles/components/namespaces.scss   | 4 ++++
 src/styles/theme/navigation.scss        | 8 ++++++++
 src/views/namespaces/ListNamespaces.vue | 4 +++-
 5 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/src/components/home/navigation.vue b/src/components/home/navigation.vue
index de0540d5a..ae8c8ef71 100644
--- a/src/components/home/navigation.vue
+++ b/src/components/home/navigation.vue
@@ -56,7 +56,7 @@
 			</ul>
 		</div>
 
-		<aside class="menu namespaces-lists">
+		<aside class="menu namespaces-lists loader-container" :class="{'is-loading': loading}">
 			<template v-for="n in namespaces">
 				<div :key="n.id">
 					<router-link
@@ -141,7 +141,7 @@
 
 <script>
 import {mapState} from 'vuex'
-import {CURRENT_LIST, IS_FULLPAGE, MENU_ACTIVE} from '@/store/mutation-types'
+import {CURRENT_LIST, IS_FULLPAGE, LOADING, MENU_ACTIVE} from '@/store/mutation-types'
 
 export default {
 	name: 'navigation',
@@ -153,6 +153,7 @@ export default {
 		currentList: CURRENT_LIST,
 		background: 'background',
 		menuActive: MENU_ACTIVE,
+		loading: LOADING,
 	}),
 	beforeCreate() {
 		this.$store.dispatch('namespaces/loadNamespaces')
diff --git a/src/store/modules/namespaces.js b/src/store/modules/namespaces.js
index 85a469198..50c01c9b8 100644
--- a/src/store/modules/namespaces.js
+++ b/src/store/modules/namespaces.js
@@ -1,6 +1,7 @@
 import Vue from 'vue'
 
 import NamespaceService from '../../services/namespace'
+import {setLoading} from '@/store/helper'
 
 export default {
 	namespaced: true,
@@ -87,6 +88,8 @@ export default {
 	},
 	actions: {
 		loadNamespaces(ctx) {
+			const cancel = setLoading(ctx)
+
 			const namespaceService = new NamespaceService()
 			// We always load all namespaces and filter them on the frontend
 			return namespaceService.getAll({}, {is_archived: true})
@@ -108,6 +111,9 @@ export default {
 				.catch(e => {
 					return Promise.reject(e)
 				})
+				.finally(() => {
+					cancel()
+				})
 		},
 		loadNamespacesIfFavoritesDontExist(ctx) {
 			// The first namespace should be the one holding all favorites
diff --git a/src/styles/components/namespaces.scss b/src/styles/components/namespaces.scss
index a85974054..d86e14736 100644
--- a/src/styles/components/namespaces.scss
+++ b/src/styles/components/namespaces.scss
@@ -16,6 +16,10 @@ $lists-per-row: 5;
     margin-bottom: 1rem;
   }
 
+  &.loader-container.is-loading {
+    min-height: calc(100vh - #{$navbar-height + 1.5rem + 1rem + 1.5rem});
+  }
+
   .namespace {
     &:not(:last-child) {
       margin-bottom: 1rem;
diff --git a/src/styles/theme/navigation.scss b/src/styles/theme/navigation.scss
index 640b8930e..5aa89c170 100644
--- a/src/styles/theme/navigation.scss
+++ b/src/styles/theme/navigation.scss
@@ -297,6 +297,14 @@
       &.namespaces-lists {
         padding-top: $navbar-padding / 2;
       }
+
+      &.loader-container.is-loading:after {
+        width: 1.5em;
+        height: 1.5em;
+        top: calc(50% - .75em);
+        left: calc(50% - .75em);
+        border-width: 2px;
+      }
     }
 
     .top-menu {
diff --git a/src/views/namespaces/ListNamespaces.vue b/src/views/namespaces/ListNamespaces.vue
index 2190eb069..447fe190b 100644
--- a/src/views/namespaces/ListNamespaces.vue
+++ b/src/views/namespaces/ListNamespaces.vue
@@ -1,5 +1,5 @@
 <template>
-	<div class="content namespaces-list">
+	<div class="content namespaces-list loader-container" :class="{'is-loading': loading}">
 		<router-link :to="{name: 'namespace.create'}" class="button is-success new-namespace">
 			<span class="icon is-small">
 				<icon icon="plus"/>
@@ -66,6 +66,7 @@
 import {mapState} from 'vuex'
 import ListService from '../../services/list'
 import Fancycheckbox from '../../components/input/fancycheckbox'
+import {LOADING} from '@/store/mutation-types'
 
 export default {
 	name: 'ListNamespaces',
@@ -89,6 +90,7 @@ export default {
 		namespaces(state) {
 			return state.namespaces.namespaces.filter(n => this.showArchived ? true : !n.isArchived)
 		},
+		loading: LOADING,
 	}),
 	methods: {
 		loadBackgroundsForLists() {