From eb0f1a977bc53eab32e857b50257ff024593452b Mon Sep 17 00:00:00 2001 From: Dominik Pschenitschni Date: Thu, 13 Jun 2024 14:22:12 +0000 Subject: [PATCH] fix(semver): fix produced version number (#2378) The "+" is not compatible and leads to problems with semver version parsers. Unsure if breaking? Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2378 Co-authored-by: Dominik Pschenitschni Co-committed-by: Dominik Pschenitschni --- docs/content/doc/setup/versions.md | 4 ++-- magefile.go | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/content/doc/setup/versions.md b/docs/content/doc/setup/versions.md index 61bfd452b..23b0f6971 100644 --- a/docs/content/doc/setup/versions.md +++ b/docs/content/doc/setup/versions.md @@ -16,7 +16,7 @@ Vikunja api is available in two different release flavors. ## Stable -Stable releases have a fixed version number like `0.18.2` and are published at irregular intervals whenever a new version is ready. +Stable releases have a fixed version number like `0.20.2` and are published at irregular intervals whenever a new version is ready. They receive few bugfixes and security patches. We use [Semantic Versioning](https://semver.org) for these releases. @@ -28,7 +28,7 @@ As such, they contain the current development code and are more likely to have b There might be multiple new such builds a day. Versions contain the last stable version, the number of commits since then and the commit the currently running binary was built from. -They look like this: `v0.18.1+269-5cc4927b9e` +They look like this: `v0.20.2-75-6049427322` Since a release is also cut from the main branch at some point, features from unstable will eventually become available in stable releases. At the point in time of a new version release, the unstable build is the same exact thing. diff --git a/magefile.go b/magefile.go index 35c21cbda..c455f543d 100644 --- a/magefile.go +++ b/magefile.go @@ -97,7 +97,6 @@ func setVersion() { os.Exit(1) } VersionNumber = strings.Trim(string(version), "\n") - VersionNumber = strings.Replace(VersionNumber, "-", "+", 1) VersionNumber = strings.Replace(VersionNumber, "-g", "-", 1) if os.Getenv("DRONE_TAG") != "" {