branchmispredictor
  • Joined on 2020-11-25
c9ab22cec7 move to keyvalue
717c3bcc0b Clean up swagger
575414b329 No need to renew token for IAP
911dffd8b3 Make IAP middleware an optional follow-up to the JWT middleware
f7642b7982 Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
8b68f453c5 Add support for identity-aware proxy login
0127ccf395 Release preparations
c52b96a31b Update dependency sass to v1.32.13 (#509)
1e64e7efad Update dependency sass-loader to v10.2.0 (#506)
1eedae2511 Update dependency vue-drag-resize to v1.5.4 (#502)
Compare 273 commits »
f7642b7982 Make IAP middleware an optional follow-up to the JWT middleware
191261a5cd Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
191261a5cd Make IAP middleware an optional follow-up to the JWT middleware
7e92a273eb Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
7e92a273eb Make IAP middleware an optional follow-up to the JWT middleware
0b82e1ddf3 Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
0b82e1ddf3 Make IAP middleware an optional follow-up to the JWT middleware
0c87a9d221 Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
0c87a9d221 Make IAP middleware an optional follow-up to the JWT middleware
e6af0ac4ee Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
e6af0ac4ee Make IAP middleware an optional follow-up to the JWT middleware
8840525b4a Make IAP middleware an optional follow-up to the JWT middleware
Compare 2 commits »
branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-18 04:19:23 +00:00
Add support to login using identity from an identity-aware proxy

Okay, I've updated the PR to make the IAP middleware more transparent as requested. Now, all the frontend needs to do is call /user/token on refresh and it will get an IAP derived token if there is…

8840525b4a Make IAP middleware an optional follow-up to the JWT middleware
f75e8fa764 Fix lint
46845897d5 Merge branch 'main' into feature/identity-aware-proxy
440e0e2b27 Fix rebase errors
93dee49b25 Fix golint errors
Compare 12 commits »
branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-17 21:35:11 +00:00
Add support to login using identity from an identity-aware proxy

Following up just to make sure I capture the implicit decisions here, so you want for the backend:

  1. If a valid jwt token is presented from the frontend, use that (e.g. ignore the IAP header) 2.…
branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-17 21:10:15 +00:00
Add support to login using identity from an identity-aware proxy

Okay, I'll give it a shot.

branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-17 20:50:16 +00:00
Add support to login using identity from an identity-aware proxy

Yes, or at least if not already logged in / if current jwt token is expired. Essentially it's similar to an open-id auth from the frontend's point of view except it 1) is hitting vikunja-backend…

branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-17 20:03:37 +00:00
Add support to login using identity from an identity-aware proxy

What I can do, is abtract this away a bit and make this an /auth/externalprovider/loggedin endpoint, so any future external auth source might also reuse the same endpoint.

branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-17 19:59:30 +00:00
Add support to login using identity from an identity-aware proxy

Since you unified the external auth providers, could you add some docs about how to add a new auth provider in the future?

@branchmispredictor I'll give it another review, I just haven't…

branchmispredictor commented on pull request vikunja/vikunja#715 2021-05-17 19:56:55 +00:00
Add support to login using identity from an identity-aware proxy

There's a problem with bootstrapping auth here. The way IAPs work is by setting an http header with claims to the downstream service (vikunja-api), however javascript or front-end code does not have…