Jef Oliver eljef
  • Joined on 2023-01-17
eljef pushed to subpath_update at eljef/api 2023-01-20 00:42:07 +00:00
e2dfcd17de fix(doc): Update Subdirectory Documentation
10e6843b11 fix(deps): update module github.com/spf13/viper to v1.15.0 (#1365)
Compare 2 commits »
eljef commented on pull request vikunja/frontend#2964 2023-01-20 00:40:58 +00:00
fix: Use Build Time Base Path

In the future, if you want to set variables to be pulled through the code base during configuration, you can add the define key in configuration and reference env. So, this is future looking by…

eljef commented on pull request vikunja/frontend#2964 2023-01-20 00:32:13 +00:00
fix: Use Build Time Base Path

OK. I think I landed on a full, final approach to supporting VIKUNJA_FRONTEND_SUBPATH and having it properly set throughout the code base.

There are two ways of setting the base path…

eljef pushed to base_path_fix at eljef/frontend 2023-01-20 00:24:41 +00:00
3bbbcf3353 feat(config): Support Setting Base Path in .env
5150daca65 fix(base): Use Build Time Base Path
a3d9cb5324 chore(deps): update pnpm to v7.25.1 (#2977)
6c192b6f59 [skip ci] Updated translations via Crowdin
Compare 4 commits »
eljef commented on pull request vikunja/frontend#2964 2023-01-19 22:34:19 +00:00
fix: Use Build Time Base Path

I've updated the documentation PR to not be WIP. I'm working on the loading of the environment file and setting the base via that method.

eljef commented on pull request vikunja/frontend#2964 2023-01-19 22:00:41 +00:00
fix: Use Build Time Base Path

OK, I did not want to close this.

eljef reopened pull request vikunja/frontend#2964 2023-01-19 22:00:41 +00:00
fix: Use Build Time Base Path
eljef commented on pull request vikunja/frontend#2964 2023-01-19 21:58:38 +00:00
fix: Use Build Time Base Path

Can you make it work?

I think I can. Now the question is, should that be included in the scope of this PR?

I think, if it is possible, that I'd like to put the env expansion work in…

eljef closed pull request vikunja/frontend#2964 2023-01-19 21:58:38 +00:00
fix: Use Build Time Base Path
eljef pushed to main at eljef/frontend 2023-01-19 21:56:33 +00:00
a3d9cb5324 chore(deps): update pnpm to v7.25.1 (#2977)
6c192b6f59 [skip ci] Updated translations via Crowdin
Compare 2 commits »
eljef pushed to main at eljef/api 2023-01-19 21:56:00 +00:00
10e6843b11 fix(deps): update module github.com/spf13/viper to v1.15.0 (#1365)
eljef commented on pull request vikunja/frontend#2964 2023-01-19 21:41:37 +00:00
fix: Use Build Time Base Path

Can you make it work?

I think I can. Now the question is, should that be included in the scope of this PR?

eljef commented on pull request vikunja/vikunja#1363 2023-01-18 21:36:05 +00:00
fix(doc): Update Subdirectory Documentation

Awesome! Can you remove the pnpm workbox copyLibraries dist/ line and replace pnpm vite build with pnpm run build. Because the [build task](https://kolaente.dev/vikunja/frontend/src/branch/

eljef pushed to subpath_update at eljef/api 2023-01-18 21:35:35 +00:00
64b00e0587 fix(doc): Update Subdirectory Documentation
eljef commented on pull request vikunja/frontend#2964 2023-01-18 21:31:24 +00:00
fix: Use Build Time Base Path

Thanks a lot! :)

The only thing I'm missing now is a line in that newly merged .env.local.example filling out…

eljef pushed to base_path_fix at eljef/frontend 2023-01-18 21:27:40 +00:00
1a8fc57ec2 fix(base): Use Build Time Base Path
8ff1b3006b fix(task): don't show the list color on the task when only viewing the list (#2975)
0414352b02 chore(deps): update dependency esbuild to v0.17.3 (#2976)
Compare 3 commits »
eljef pushed to main at eljef/frontend 2023-01-18 21:27:21 +00:00
8ff1b3006b fix(task): don't show the list color on the task when only viewing the list (#2975)
0414352b02 chore(deps): update dependency esbuild to v0.17.3 (#2976)
Compare 2 commits »
eljef commented on pull request vikunja/frontend#2964 2023-01-18 17:06:48 +00:00
fix: Use Build Time Base Path

Patch updated and pushed. The PR's message has been updated.

The base path is now set from VIKUNJA_FRONTEND_SUBPATH. This correctly sets all paths. This is also future facing as when you…

eljef pushed to subpath_update at eljef/api 2023-01-18 16:59:35 +00:00
dabe14b9fb fix(doc): Update Subdirectory Documentation
78f43829cf fix(deps): update module src.techknowlogick.com/xgo to v1.7.0+1.19.5 (#1364)
Compare 2 commits »
eljef pushed to main at eljef/api 2023-01-18 16:59:14 +00:00
78f43829cf fix(deps): update module src.techknowlogick.com/xgo to v1.7.0+1.19.5 (#1364)