I think we only need to set Vites base option with VIKUNJA_FRONTEND_SUBPATH.
Does this cover the case where the user uses --base AND
VIKUNJA_FRONTEND_SUBPATH? I don't want to have the…
Anyway, that's probably nitpicking now.
It really feels like it, I know! Sorry also @eljef.
I'm used to arguing over patches via mailing lists. The level of nitpicking comes down to…
vikunja/frontend#2964 is updated accordingly. This documentation update is still needed to clarify the need for a trailing slash. Pending the approval of the front-end PR.
Updated commit in place and it is quite minimal now.
I will explore making this more dynamic in the future. I'd like to not build each release if I can help it :)
./ fixes the issue with loading of the PWA from a sub-directory. Using that here.
I found this comment from the vue router author. Considering this we really should use vites base option in the configuratio…
This is the only usage of process.env.BASE_URL in the patch. When base: is undefined, it falls back to '/'. I've built and tested this a few times now.
However, to handle this case as a…
BASE_URL=/SUBPATH/ && pnpm run build
process.env.BASE_URL does not set import.meta.env.BASE_URL. This is actually set in the inverse. import.meta.env.BASE_URL sets…
I'm 100% willing to do this. What repo are the docs located in?
Awesome! They are here: https://kolaente.dev/vikunja/api/src/branch/main/docs/content/doc/setup/subdirectory.md
PR…
Requires vikunja/frontend#2964
WIP until other is merged.