Jef Oliver eljef
  • Joined on 2023-01-17
eljef commented on pull request vikunja/frontend#2964 2023-01-17 16:39:19 +00:00
fix: Use Build Time Base Path

I've changed to use this.

eljef commented on pull request vikunja/frontend#2964 2023-01-17 16:35:43 +00:00
fix: Use Build Time Base Path

If this PR is approved after any requested changes, the only change will be is that --base=/path requires a trailing slash: --base=/path/

Can you open a follow up to the docs once this…

eljef commented on pull request vikunja/frontend#2964 2023-01-17 16:24:30 +00:00
fix: Use Build Time Base Path

I followed this process, and ran into the issues that led to me submitting this PR.

Okay, but do we need to update the docs?

If this PR is approved after any requested changes, the…

eljef commented on pull request vikunja/frontend#2964 2023-01-17 16:23:27 +00:00
fix: Use Build Time Base Path

process.env.BASE_URL is set by --base along with import.meta.env.BASE_URL.

WARNING] "import.meta" is not available with the "cjs" output format and will be empty [empty-import-meta]

eljef commented on pull request vikunja/frontend#2964 2023-01-17 16:12:05 +00:00
fix: Use Build Time Base Path

It's just that we don't use vue cli, only vite. You probably mean https://vitejs.dev/guide/build.html#public-base-path for docs.

While vue cli is not used, the variable is still set and used…

eljef commented on pull request vikunja/frontend#2964 2023-01-17 15:57:40 +00:00
fix: Use Build Time Base Path

I've pushed an update using createWebHistory with a base set as an argument. This does work for me with the subfolder. Thank you @konrad for pointing that out.

eljef pushed to base_path_fix at eljef/frontend 2023-01-17 15:54:53 +00:00
bb5f00775f fix(base): Use Build Time Base
da26ec7f1c fix(deps): update sentry-javascript monorepo to v7.31.1 (#2973)
14466bf9b7 feat: add describe project better in package.json (#2971)
903e9a9904 chore: add has content="false" to gantt charts (#2969)
56fd25e888 chore: improve migrate title (#2968)
Compare 8 commits »
eljef commented on pull request vikunja/frontend#2964 2023-01-17 15:41:49 +00:00
fix: Use Build Time Base Path

Usages of process.env.BASE_URL are statically replaced at build time.

I am not sure about this. Where in the docs did you get this from? it was the case in vue-cli. In vite you would…

eljef commented on pull request vikunja/frontend#2964 2023-01-17 15:40:29 +00:00
fix: Use Build Time Base Path

Even setting the base option in vite, the PWA setup does not pull that base path. I had to explicitly set it so that the PWA would be pulled from the correct path.

eljef commented on pull request vikunja/frontend#2964 2023-01-17 15:39:39 +00:00
fix: Use Build Time Base Path

I could not get the basepath options to work, and did not know about the createWebHistory. I can rework this part to use it.

eljef commented on pull request vikunja/frontend#2964 2023-01-17 15:38:49 +00:00
fix: Use Build Time Base Path

Hey, thanks for the pull request.

Documentation: https://cli.vuejs.org/guide/mode-and-env.html

This link is from vue-cli, probably you wantws to paste the other link here as…

eljef commented on pull request vikunja/frontend#2964 2023-01-17 04:54:32 +00:00
fix: Use Build Time Base Path

All of the areas that are patched were identified through running the app in a test deployment using a sub-directory for the base.

This fixes issues with the service worker URL not being…

eljef created pull request vikunja/frontend#2964 2023-01-17 04:51:20 +00:00
fix(base): Use Build Time Base
eljef created branch base_path_fix in eljef/frontend 2023-01-17 04:44:52 +00:00
eljef pushed to base_path_fix at eljef/frontend 2023-01-17 04:44:52 +00:00
9a0da60536 fix(base): Use Build Time Base
eljef created repository eljef/frontend 2023-01-17 04:43:50 +00:00