From 4b903c4f48a4636c3b91e72fe8436ce22e2ceafa Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Tue, 19 Mar 2024 00:46:18 +0100
Subject: [PATCH] fix(views): lint

---
 .../src/components/project/ProjectWrapper.vue |   7 +-
 .../project/partials/FilterInput.vue          |   5 +-
 .../project/views/ProjectKanban.vue           |   2 +-
 .../components/project/views/ProjectList.vue  |   6 +-
 .../components/project/views/ProjectTable.vue |   2 +-
 .../components/project/views/viewEditForm.vue |  13 +-
 frontend/src/composables/useTaskList.ts       |   2 +-
 frontend/src/helpers/projectView.ts           |   1 -
 frontend/src/stores/kanban.ts                 |   2 -
 frontend/src/stores/tasks.ts                  |   3 +-
 frontend/src/views/project/ProjectView.vue    |  13 +-
 frontend/src/views/project/settings/views.vue | 114 +++++++++---------
 .../src/views/sharing/LinkSharingAuth.vue     |   2 +-
 13 files changed, 81 insertions(+), 91 deletions(-)

diff --git a/frontend/src/components/project/ProjectWrapper.vue b/frontend/src/components/project/ProjectWrapper.vue
index dd843629c8..8d23f76299 100644
--- a/frontend/src/components/project/ProjectWrapper.vue
+++ b/frontend/src/components/project/ProjectWrapper.vue
@@ -11,6 +11,7 @@
 			<div class="switch-view">
 				<BaseButton
 					v-for="v in views"
+					:key="v.id"
 					class="switch-view-button"
 					:class="{'is-active': v.id === viewId}"
 					:to="{ name: 'project.view', params: { projectId, viewId: v.id } }"
@@ -18,7 +19,7 @@
 					{{ getViewTitle(v) }}
 				</BaseButton>
 			</div>
-			<slot name="header"/>
+			<slot name="header" />
 		</div>
 		<CustomTransition name="fade">
 			<Message
@@ -30,7 +31,7 @@
 			</Message>
 		</CustomTransition>
 
-		<slot v-if="loadedProjectId"/>
+		<slot v-if="loadedProjectId" />
 	</div>
 </template>
 
@@ -109,7 +110,7 @@ watch(
 			return
 		}
 
-		console.debug(`Loading project, $route.params =`, route.params, `, loadedProjectId = ${loadedProjectId.value}, currentProject = `, currentProject.value)
+		console.debug('Loading project, $route.params =', route.params, `, loadedProjectId = ${loadedProjectId.value}, currentProject = `, currentProject.value)
 
 		// Set the current project to the one we're about to load so that the title is already shown at the top
 		loadedProjectId.value = 0
diff --git a/frontend/src/components/project/partials/FilterInput.vue b/frontend/src/components/project/partials/FilterInput.vue
index 46f6008bb9..560fe84380 100644
--- a/frontend/src/components/project/partials/FilterInput.vue
+++ b/frontend/src/components/project/partials/FilterInput.vue
@@ -21,11 +21,8 @@ import {
 	LABEL_FIELDS,
 } from '@/helpers/filters'
 import {useDebounceFn} from '@vueuse/core'
-import {useI18n} from 'vue-i18n'
 import {createRandomID} from '@/helpers/randomId'
 
-const {t} = useI18n()
-
 const {
 	modelValue,
 	projectId,
@@ -270,9 +267,9 @@ const blurDebounced = useDebounceFn(() => emit('blur'), 500)
 			>
 				<div class="control filter-input">
 					<textarea
+						:id
 						ref="filterInput"
 						v-model="filterQuery"
-						:id
 						autocomplete="off"
 						autocorrect="off"
 						autocapitalize="off"
diff --git a/frontend/src/components/project/views/ProjectKanban.vue b/frontend/src/components/project/views/ProjectKanban.vue
index 91ea8b6dfc..d36a63a494 100644
--- a/frontend/src/components/project/views/ProjectKanban.vue
+++ b/frontend/src/components/project/views/ProjectKanban.vue
@@ -2,7 +2,7 @@
 	<ProjectWrapper
 		class="project-kanban"
 		:project-id="projectId"
-		:viewId
+		:view-id
 	>
 		<template #header>
 			<div class="filter-container">
diff --git a/frontend/src/components/project/views/ProjectList.vue b/frontend/src/components/project/views/ProjectList.vue
index 12f698f36e..d19de33575 100644
--- a/frontend/src/components/project/views/ProjectList.vue
+++ b/frontend/src/components/project/views/ProjectList.vue
@@ -2,7 +2,7 @@
 	<ProjectWrapper
 		class="project-list"
 		:project-id="projectId"
-		:viewId
+		:view-id
 	>
 		<template #header>
 			<div class="filter-container">
@@ -73,7 +73,7 @@
 							>
 								<template v-if="canWrite">
 									<span class="icon handle">
-										<icon icon="grip-lines"/>
+										<icon icon="grip-lines" />
 									</span>
 								</template>
 							</SingleTaskInProject>
@@ -114,7 +114,6 @@ import type {ITask} from '@/modelTypes/ITask'
 import {isSavedFilter} from '@/services/savedFilter'
 
 import {useBaseStore} from '@/stores/base'
-import {useTaskStore} from '@/stores/tasks'
 
 import type {IProject} from '@/modelTypes/IProject'
 import type {IProjectView} from '@/modelTypes/IProjectView'
@@ -189,7 +188,6 @@ const firstNewPosition = computed(() => {
 	return calculateItemPosition(null, tasks.value[0].position)
 })
 
-const taskStore = useTaskStore()
 const baseStore = useBaseStore()
 const project = computed(() => baseStore.currentProject)
 
diff --git a/frontend/src/components/project/views/ProjectTable.vue b/frontend/src/components/project/views/ProjectTable.vue
index 86b434f6b8..9393ed559b 100644
--- a/frontend/src/components/project/views/ProjectTable.vue
+++ b/frontend/src/components/project/views/ProjectTable.vue
@@ -2,7 +2,7 @@
 	<ProjectWrapper
 		class="project-table"
 		:project-id="projectId"
-		:viewId
+		:view-id
 	>
 		<template #header>
 			<div class="filter-container">
diff --git a/frontend/src/components/project/views/viewEditForm.vue b/frontend/src/components/project/views/viewEditForm.vue
index e555790f3e..55a60f0d4f 100644
--- a/frontend/src/components/project/views/viewEditForm.vue
+++ b/frontend/src/components/project/views/viewEditForm.vue
@@ -117,11 +117,14 @@ function validateTitle() {
 						class="is-danger"
 						@click.prevent="() => model.bucketConfiguration.splice(index, 1)"
 					>
-						<icon icon="trash-alt"/>
+						<icon icon="trash-alt" />
 					</button>
 					<div class="filter-bucket-form">
 						<div class="field">
-							<label class="label" :for="'bucket_'+index+'_title'">
+							<label
+								class="label"
+								:for="'bucket_'+index+'_title'"
+							>
 								{{ $t('project.views.title') }}
 							</label>
 							<div class="control">
@@ -136,18 +139,18 @@ function validateTitle() {
 
 						<FilterInput
 							v-model="model.bucketConfiguration[index].filter"
-							:inputLabel="$t('project.views.filter')"
+							:input-label="$t('project.views.filter')"
 						/>
 					</div>
 				</div>
 				<div class="is-flex is-justify-content-end">
-					<x-button
+					<XButton
 						variant="secondary"
 						icon="plus"
 						@click="() => model.bucketConfiguration.push({title: '', filter: ''})"
 					>
 						{{ $t('project.kanban.addBucket') }}
-					</x-button>
+					</XButton>
 				</div>
 			</div>
 		</div>
diff --git a/frontend/src/composables/useTaskList.ts b/frontend/src/composables/useTaskList.ts
index 151a4e9f26..27a8ab6eb6 100644
--- a/frontend/src/composables/useTaskList.ts
+++ b/frontend/src/composables/useTaskList.ts
@@ -58,7 +58,7 @@ const SORT_BY_DEFAULT: SortBy = {
 export function useTaskList(
 	projectIdGetter: ComputedGetter<IProject['id']>,
 	projectViewIdGetter: ComputedGetter<IProjectView['id']>,
-	sortByDefault: SortBy = SORT_BY_DEFAULT
+	sortByDefault: SortBy = SORT_BY_DEFAULT,
 ) {
 	
 	const projectId = computed(() => projectIdGetter())
diff --git a/frontend/src/helpers/projectView.ts b/frontend/src/helpers/projectView.ts
index 285f6c2efc..fd34bbdb23 100644
--- a/frontend/src/helpers/projectView.ts
+++ b/frontend/src/helpers/projectView.ts
@@ -1,4 +1,3 @@
-import type { RouteRecordName } from 'vue-router'
 import router from '@/router'
 
 import type {IProject} from '@/modelTypes/IProject'
diff --git a/frontend/src/stores/kanban.ts b/frontend/src/stores/kanban.ts
index d31dc8c4ed..9cf8c94d5d 100644
--- a/frontend/src/stores/kanban.ts
+++ b/frontend/src/stores/kanban.ts
@@ -3,8 +3,6 @@ import {acceptHMRUpdate, defineStore} from 'pinia'
 import {klona} from 'klona/lite'
 
 import {findById, findIndexById} from '@/helpers/utils'
-import {i18n} from '@/i18n'
-import {success} from '@/message'
 
 import BucketService from '@/services/bucket'
 import TaskCollectionService, {type TaskFilterParams} from '@/services/taskCollection'
diff --git a/frontend/src/stores/tasks.ts b/frontend/src/stores/tasks.ts
index faef5881c5..8a55c1065f 100644
--- a/frontend/src/stores/tasks.ts
+++ b/frontend/src/stores/tasks.ts
@@ -28,9 +28,8 @@ import {useKanbanStore} from '@/stores/kanban'
 import {useBaseStore} from '@/stores/base'
 import ProjectUserService from '@/services/projectUsers'
 import {useAuthStore} from '@/stores/auth'
-import TaskCollectionService, {type TaskFilterParams} from '@/services/taskCollection'
+import {type TaskFilterParams} from '@/services/taskCollection'
 import {getRandomColorHex} from '@/helpers/color/randomColor'
-import type {IProjectView} from '@/modelTypes/IProjectView'
 
 interface MatchedAssignee extends IUser {
 	match: string,
diff --git a/frontend/src/views/project/ProjectView.vue b/frontend/src/views/project/ProjectView.vue
index c51e7ebfdb..e7d5371d3e 100644
--- a/frontend/src/views/project/ProjectView.vue
+++ b/frontend/src/views/project/ProjectView.vue
@@ -31,6 +31,7 @@ watch(
 		if (viewId === 0) {
 			// Ideally, we would do that in the router redirect, but we the projects (and therefore, the views) 
 			// are not always loaded then.
+			console.log('views', projectId, projectStore.projects)
 			const viewId = projectStore.projects[projectId].views[0].id
 			router.replace({
 				name: 'project.view',
@@ -51,25 +52,21 @@ const route = useRoute()
 	<ProjectList
 		v-if="currentView?.viewKind === 'list'"
 		:project-id="projectId"
-		:viewId
+		:view-id
 	/>
 	<ProjectGantt
 		v-if="currentView?.viewKind === 'gantt'"
 		:route
-		:viewId
+		:view-id
 	/>
 	<ProjectTable
 		v-if="currentView?.viewKind === 'table'"
 		:project-id="projectId"
-		:viewId
+		:view-id
 	/>
 	<ProjectKanban
 		v-if="currentView?.viewKind === 'kanban'"
 		:project-id="projectId"
-		:viewId
+		:view-id
 	/>
 </template>
-
-<style scoped lang="scss">
-
-</style>
\ No newline at end of file
diff --git a/frontend/src/views/project/settings/views.vue b/frontend/src/views/project/settings/views.vue
index 07fe02d00c..e39fe34d82 100644
--- a/frontend/src/views/project/settings/views.vue
+++ b/frontend/src/views/project/settings/views.vue
@@ -90,12 +90,12 @@ async function saveView() {
 			class="mb-4"
 		/>
 		<div class="is-flex is-justify-content-end">
-			<x-button
-				@click="createView"
+			<XButton
 				:loading="projectViewService.loading"
+				@click="createView"
 			>
 				{{ $t('project.views.create') }}
-			</x-button>
+			</XButton>
 		</div>
 
 		<table
@@ -103,59 +103,61 @@ async function saveView() {
 			class="table has-actions is-striped is-hoverable is-fullwidth"
 		>
 			<thead>
-			<tr>
-				<th>{{ $t('project.views.title') }}</th>
-				<th>{{ $t('project.views.kind') }}</th>
-				<th class="has-text-right">{{ $t('project.views.actions') }}</th>
-			</tr>
+				<tr>
+					<th>{{ $t('project.views.title') }}</th>
+					<th>{{ $t('project.views.kind') }}</th>
+					<th class="has-text-right">
+						{{ $t('project.views.actions') }}
+					</th>
+				</tr>
 			</thead>
 			<tbody>
-			<tr
-				v-for="v in views"
-				:key="v.id"
-			>
-				<template v-if="viewToEdit !== null && viewToEdit.id === v.id">
-					<td colspan="3">
-						<ViewEditForm
-							v-model="viewToEdit"
-							class="mb-4"
-						/>
-						<div class="is-flex is-justify-content-end">
-							<x-button
-								variant="tertiary"
-								@click="viewToEdit = null"
-								class="mr-2"
-							>
-								{{ $t('misc.cancel') }}
-							</x-button>
-							<x-button
-								@click="saveView"
-								:loading="projectViewService.loading"
-							>
-								{{ $t('misc.save') }}
-							</x-button>
-						</div>
-					</td>
-				</template>
-				<template v-else>
-					<td>{{ v.title }}</td>
-					<td>{{ v.viewKind }}</td>
-					<td class="has-text-right">
-						<x-button
-							class="is-danger mr-2"
-							icon="trash-alt"
-							@click="() => {
-							viewIdToDelete = v.id
-							showDeleteModal = true
-						}"
-						/>
-						<x-button
-							icon="pen"
-							@click="viewToEdit = {...v}"
-						/>
-					</td>
-				</template>
-			</tr>
+				<tr
+					v-for="v in views"
+					:key="v.id"
+				>
+					<template v-if="viewToEdit !== null && viewToEdit.id === v.id">
+						<td colspan="3">
+							<ViewEditForm
+								v-model="viewToEdit"
+								class="mb-4"
+							/>
+							<div class="is-flex is-justify-content-end">
+								<XButton
+									variant="tertiary"
+									class="mr-2"
+									@click="viewToEdit = null"
+								>
+									{{ $t('misc.cancel') }}
+								</XButton>
+								<XButton
+									:loading="projectViewService.loading"
+									@click="saveView"
+								>
+									{{ $t('misc.save') }}
+								</XButton>
+							</div>
+						</td>
+					</template>
+					<template v-else>
+						<td>{{ v.title }}</td>
+						<td>{{ v.viewKind }}</td>
+						<td class="has-text-right">
+							<XButton
+								class="is-danger mr-2"
+								icon="trash-alt"
+								@click="() => {
+									viewIdToDelete = v.id
+									showDeleteModal = true
+								}"
+							/>
+							<XButton
+								icon="pen"
+								@click="viewToEdit = {...v}"
+							/>
+						</td>
+					</template>
+				</tr>
 			</tbody>
 		</table>
 	</CreateEdit>
@@ -174,7 +176,3 @@ async function saveView() {
 		</template>
 	</modal>
 </template>
-
-<style scoped lang="scss">
-
-</style>
\ No newline at end of file
diff --git a/frontend/src/views/sharing/LinkSharingAuth.vue b/frontend/src/views/sharing/LinkSharingAuth.vue
index 34e48db1c3..b10daad40e 100644
--- a/frontend/src/views/sharing/LinkSharingAuth.vue
+++ b/frontend/src/views/sharing/LinkSharingAuth.vue
@@ -109,7 +109,7 @@ function useAuth() {
 				name: 'project.view',
 				params: {
 					projectId, 
-					viewId: route.query.view
+					viewId: route.query.view,
 				},
 				hash,
 			})