Add better tests for namespaces

pkg/models/namespace_test.go

@@ -20,15 +20,10 @@ import (
 	"code.vikunja.io/api/pkg/db"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/stretchr/testify/assert"
-	"reflect"
 	"testing"
 )
 
 func TestNamespace_Create(t *testing.T) {
-	db.LoadAndAssertFixtures(t)
-
-	// Create test database
-	//assert.NoError(t, LoadFixtures())
 
 	// Dummy namespace
 	dummynamespace := Namespace{
@@ -36,95 +31,137 @@ func TestNamespace_Create(t *testing.T) {
 		Description: "Lorem Ipsum",
 	}
 
-	// Doer
+	user1 := &user.User{ID: 1}
-	doer, err := user.GetUserByID(1)
-	assert.NoError(t, err)
 
-	// Try creating it
+	t.Run("normal", func(t *testing.T) {
-	allowed, _ := dummynamespace.CanCreate(doer)
+		db.LoadAndAssertFixtures(t)
-	assert.True(t, allowed)
+		err := dummynamespace.Create(user1)
-	err = dummynamespace.Create(doer)
 		assert.NoError(t, err)
-
+	})
-	// check if it really exists
+	t.Run("no title", func(t *testing.T) {
-	allowed, _, err = dummynamespace.CanRead(doer)
+		db.LoadAndAssertFixtures(t)
-	assert.NoError(t, err)
-	assert.True(t, allowed)
-	err = dummynamespace.ReadOne()
-	assert.NoError(t, err)
-	assert.Equal(t, dummynamespace.Title, "Test")
-
-	// Try creating one without a name
 		n2 := Namespace{}
-	err = n2.Create(doer)
+		err := n2.Create(user1)
 		assert.Error(t, err)
 		assert.True(t, IsErrNamespaceNameCannotBeEmpty(err))
-
+	})
-	// Try inserting one with a nonexistant user
+	t.Run("nonexistant user", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
 		nUser := &user.User{ID: 9482385}
 		dnsp2 := dummynamespace
-	err = dnsp2.Create(nUser)
+		err := dnsp2.Create(nUser)
 		assert.Error(t, err)
 		assert.True(t, user.IsErrUserDoesNotExist(err))
+	})
+}
 
-	// Update it
+func TestNamespace_ReadOne(t *testing.T) {
-	allowed, err = dummynamespace.CanUpdate(doer)
+	t.Run("normal", func(t *testing.T) {
-	assert.NoError(t, err)
+		n := &Namespace{ID: 1}
-	assert.True(t, allowed)
+		db.LoadAndAssertFixtures(t)
-	dummynamespace.Description = "Dolor sit amet."
+		err := n.ReadOne()
-	err = dummynamespace.Update()
 		assert.NoError(t, err)
+		assert.Equal(t, n.Title, "testnamespace")
+	})
+	t.Run("nonexistant", func(t *testing.T) {
+		n := &Namespace{ID: 99999}
+		db.LoadAndAssertFixtures(t)
+		err := n.ReadOne()
+		assert.Error(t, err)
+		assert.True(t, IsErrNamespaceDoesNotExist(err))
+	})
+}
 
-	// Check if it was updated
+func TestNamespace_Update(t *testing.T) {
-	assert.Equal(t, "Dolor sit amet.", dummynamespace.Description)
+	t.Run("normal", func(t *testing.T) {
-	// Get it and check it again
+		db.LoadAndAssertFixtures(t)
-	allowed, _, err = dummynamespace.CanRead(doer)
+		n := &Namespace{
+			ID:    1,
+			Title: "Lorem Ipsum",
+		}
+		err := n.Update()
 		assert.NoError(t, err)
-	assert.True(t, allowed)
+	})
-	err = dummynamespace.ReadOne()
+	t.Run("nonexisting", func(t *testing.T) {
-	assert.NoError(t, err)
+		db.LoadAndAssertFixtures(t)
-	assert.Equal(t, "Dolor sit amet.", dummynamespace.Description)
+		n := &Namespace{
-
+			ID:    99999,
-	// Try updating one with a nonexistant owner
+			Title: "Lorem Ipsum",
-	dummynamespace.Owner.ID = 999999
+		}
-	err = dummynamespace.Update()
+		err := n.Update()
+		assert.Error(t, err)
+		assert.True(t, IsErrNamespaceDoesNotExist(err))
+	})
+	t.Run("nonexisting owner", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		n := &Namespace{
+			ID:    1,
+			Title: "Lorem Ipsum",
+			Owner: &user.User{ID: 99999},
+		}
+		err := n.Update()
 		assert.Error(t, err)
 		assert.True(t, user.IsErrUserDoesNotExist(err))
-
+	})
-	// Try updating without a name
+	t.Run("no title", func(t *testing.T) {
-	dummynamespace.Title = ""
+		db.LoadAndAssertFixtures(t)
-	err = dummynamespace.Update()
+		n := &Namespace{
+			ID: 1,
+		}
+		err := n.Update()
 		assert.Error(t, err)
 		assert.True(t, IsErrNamespaceNameCannotBeEmpty(err))
-
+	})
-	// Try updating a nonexistant one
+}
-	n := Namespace{ID: 284729, Title: "Lorem"}
+
-	err = n.Update()
+func TestNamespace_Delete(t *testing.T) {
-	assert.Error(t, err)
+	t.Run("normal", func(t *testing.T) {
-	assert.True(t, IsErrNamespaceDoesNotExist(err))
+		db.LoadAndAssertFixtures(t)
-
+		n := &Namespace{
-	// Delete it
+			ID: 1,
-	allowed, err = dummynamespace.CanDelete(doer)
+		}
-	assert.NoError(t, err)
+		err := n.Delete()
-	assert.True(t, allowed)
+		assert.NoError(t, err)
-	err = dummynamespace.Delete()
+	})
-	assert.NoError(t, err)
+	t.Run("nonexisting", func(t *testing.T) {
-
+		db.LoadAndAssertFixtures(t)
-	// Try deleting a nonexistant one
+		n := &Namespace{
-	err = n.Delete()
+			ID: 9999,
-	assert.Error(t, err)
+		}
-	assert.True(t, IsErrNamespaceDoesNotExist(err))
+		err := n.Delete()
-
+		assert.Error(t, err)
-	// Check if it was successfully deleted
+		assert.True(t, IsErrNamespaceDoesNotExist(err))
-	allowed, _, err = dummynamespace.CanRead(doer)
+	})
-	assert.False(t, allowed)
+}
-	assert.Error(t, err)
+
-	assert.True(t, IsErrNamespaceDoesNotExist(err))
+func TestNamespace_ReadAll(t *testing.T) {
-
+	user1 := &user.User{ID: 1}
-	// Get all namespaces of a user
+
-	nsps, _, _, err := n.ReadAll(doer, "", 1, 50)
+	t.Run("normal", func(t *testing.T) {
-	assert.NoError(t, err)
+		n := &Namespace{}
-	assert.Equal(t, reflect.TypeOf(nsps).Kind(), reflect.Slice)
+		nn, _, _, err := n.ReadAll(user1, "", 1, -1)
-	s := reflect.ValueOf(nsps)
+		namespaces := nn.([]*NamespaceWithLists)
-	assert.Equal(t, 9, s.Len())
+		assert.NoError(t, err)
+		assert.NotNil(t, namespaces)
+		assert.Len(t, namespaces, 9)                 // Total of 9 including shared
+		assert.Equal(t, int64(-1), namespaces[0].ID) // The first one should be the one with the shared namespaces
+		// Ensure every list and namespace are not archived
+		for _, namespace := range namespaces {
+			assert.False(t, namespace.IsArchived)
+			for _, list := range namespace.Lists {
+				assert.False(t, list.IsArchived)
+			}
+		}
+	})
+	t.Run("archived", func(t *testing.T) {
+		n := &Namespace{
+			IsArchived: true,
+		}
+		nn, _, _, err := n.ReadAll(user1, "", 1, -1)
+		namespaces := nn.([]*NamespaceWithLists)
+		assert.NoError(t, err)
+		assert.NotNil(t, namespaces)
+		assert.Len(t, namespaces, 10)                // Total of 10 including shared, one is archived
+		assert.Equal(t, int64(-1), namespaces[0].ID) // The first one should be the one with the shared namespaces
+	})
 }