konrad
/
docker-db-backup
2
4
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

fix: make mysql backups work
continuous-integration/drone/push Build is passing Details

This commit is contained in:
kolaente 2023-07-03 22:46:38 +02:00
parent 8bbf77ccff
commit 54a1eb955b
Signed by: konrad
GPG Key ID: F40E70337AB24C9B
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dump_mysql.go
View File

@ -41,7 +41,15 @@ func (m *MysqlDumper) buildDumpArgs() []string {
host := m.Container.NetworkSettings.DefaultNetworkSettings.IPAddress
args := []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", user}
args := []string{
"--lock-tables=0",
"--dump-date",
"--single-transaction",
"--routines",
"--triggers",
"--events",
"-u", user,
}
if pw != "" {
args = append(args, "-p"+pw)

12
dump_mysql_test.go
View File

@ -31,7 +31,7 @@ func TestMysqlDumper_buildDumpArgs(t *testing.T) {
},
},
},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "notapassword", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "notapassword", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
},
{
name: "no user",
@ -45,7 +45,7 @@ func TestMysqlDumper_buildDumpArgs(t *testing.T) {
},
},
},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", "root", "-p" + "notapassword", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--routines", "--triggers", "--events", "-u", "root", "-p" + "notapassword", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
},
{
name: "no password",
@ -59,7 +59,7 @@ func TestMysqlDumper_buildDumpArgs(t *testing.T) {
},
},
},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", "loremipsum", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--routines", "--triggers", "--events", "-u", "loremipsum", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
},
{
name: "no password, but root",
@ -74,7 +74,7 @@ func TestMysqlDumper_buildDumpArgs(t *testing.T) {
},
},
},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "roooot", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "roooot", "--port", "1234", "-h", "1.2.3.4", "ipsum"},
},
{
name: "no port",
@ -88,7 +88,7 @@ func TestMysqlDumper_buildDumpArgs(t *testing.T) {
},
},
},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "notapassword", "--port", "3306", "-h", "1.2.3.4", "ipsum"},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "notapassword", "--port", "3306", "-h", "1.2.3.4", "ipsum"},
},
{
name: "no db",
@ -102,7 +102,7 @@ func TestMysqlDumper_buildDumpArgs(t *testing.T) {
},
},
},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--source-data=2", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "notapassword", "--port", "1234", "-h", "1.2.3.4", "--all-databases"},
want: []string{"--lock-tables=0", "--dump-date", "--single-transaction", "--routines", "--triggers", "--events", "-u", "loremipsum", "-p" + "notapassword", "--port", "1234", "-h", "1.2.3.4", "--all-databases"},
},
}
for _, tt := range tests {