viehlieb
  • freelance software developer @local-it @pragma-shift @foodsoft

  • Joined on 2022-10-12
viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-12-06 13:44:06 +00:00
06c849bf81 tiny changes in openid.go, revert error.go, link to docs
viehlieb commented on pull request vikunja/vikunja#1393 2023-12-06 13:37:36 +00:00
feat: assign users to teams via OIDC claims

only if it has teamIDsToLeave, but yeah I agree.

The problem is more the oidc structure itself, that you "have" to check for changes "everytime" you sign in..

viehlieb commented on pull request vikunja/vikunja#1393 2023-12-06 13:05:55 +00:00
feat: assign users to teams via OIDC claims

If you have a look at:

3643ffe0d0/src/helpers/redirectToProvider.ts (L18)

You'll see the hardcoded scope. But to…

viehlieb commented on pull request vikunja/vikunja#1393 2023-12-06 12:18:27 +00:00
feat: assign users to teams via OIDC claims

one is the required scope, which has to be customized -> vikunja_scope another one is a key for the groups within this scope -> vikunja_groups.

viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-12-01 12:12:06 +00:00
c2dc6d0e39 fix lint and add test
0224fc5450 tests and fixes
6ef294f0ee delete sso teams on login if empty
9a25a0c9fd minor changes in teams.go and consistent attribute renaming in openid.md
ff6546ffea use one sql query for removing user form team
Compare 106 commits »
viehlieb pushed to main at viehlieb/api 2023-12-01 11:57:51 +00:00
c6c465c273 feat: make unauthenticated user routes rate limit configurable
f26f1326ea chore(deps): update github.com/go-jose/go-jose/v3
bbc8da1e80 fix(tests): pass the map
df1f95871a fix(projects): correctly set project's archived state if their parent was archived
5da1075f88 [skip ci] Updated swagger docs
Compare 357 commits »
viehlieb commented on pull request vikunja/vikunja#1393 2023-11-30 15:35:22 +00:00
feat: assign users to teams via OIDC claims

@waza-ari you can do sth like Screenshot from 2023-11-30 16-32-06.png

But i could not find out how to add codestyle `user.groups.each…

viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-11-30 13:40:48 +00:00
8cb3652a3e fix lint and add test
2ffcad1db3 tests and fixes
Compare 2 commits »
viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-11-08 13:50:24 +00:00
4f48cc6793 delete sso teams on login if empty
viehlieb commented on pull request vikunja/vikunja#1393 2023-11-08 11:51:31 +00:00
feat: assign users to teams via OIDC claims

went for:

_, err = s.Where("team_id IN (?) AND user_id = ?", strings.Join(strSlice, ","), u.ID).Delete(&models.TeamMember{})

viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-11-08 11:44:35 +00:00
c9869c7e96 minor changes in teams.go and consistent attribute renaming in openid.md
317f17eaaa use one sql query for removing user form team
Compare 2 commits »
viehlieb commented on pull request vikunja/vikunja#1393 2023-11-07 15:14:54 +00:00
feat: assign users to teams via OIDC claims

You mean something like:

func RemoveUserFromTeamsByIds(s *xorm.Session, u *user.User, teamIDs []int64) (err error) {

	if len(teamIDs) < 1 {
		return nil
	}

	strSlice := make([]strin…
viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-11-07 14:27:19 +00:00
88b13f68c6 tiny changes in openid.md
8dee24bb25 fix lint
5111b87f25 fix typos
f7267ff46d do-the swag
Compare 4 commits »
viehlieb commented on pull request vikunja/vikunja#1393 2023-11-07 14:16:57 +00:00
feat: assign users to teams via OIDC claims

i think it was cyclomatic complexity.

viehlieb commented on pull request vikunja/vikunja#1393 2023-11-07 14:01:11 +00:00
feat: assign users to teams via OIDC claims

in authentik it is called oidcID

in migration:

type teams20230104152903 struct {
	OidcID string `xorm:"varchar(250) null" maxLength:"250" json:"oidc_id"`
}

Therefore in the…

viehlieb commented on pull request vikunja/vikunja#1393 2023-11-07 13:41:23 +00:00
feat: assign users to teams via OIDC claims

if a member sits on a team as last member, then the member cannot leave other teams. ...is edited. I meant: the member cannot leave this team, if it is the last membership.

where the…

viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-10-27 14:30:41 +00:00
5c0e60ae9c fixsomerebase errs
viehlieb pushed to 950_reworked_assign_teams_via_oidc at viehlieb/api 2023-10-27 14:24:22 +00:00
2377d816df change openid.md directory, modify openid.md
1b390fbc95 change error note and append team pointer in GetOrCreateTeamsByOIDCAndNames
193ef53df8 return pointer to team
d7e7752c22 add to error.md change error msg
f4b9e5989a fix rebase error
Compare 401 commits »
viehlieb commented on pull request vikunja/vikunja#1393 2023-10-18 14:33:26 +00:00
feat: assign users to teams via OIDC claims

hallo, ich habe gesehen, dass der alte PR geschlossen wurde. Wie sieht es denn hiermit aus? Die Changes sind alle eingearbeitet.. lg

viehlieb commented on pull request vikunja/vikunja#1393 2023-06-22 09:18:24 +00:00
feat: assign users to teams via OIDC claims

it is supposed to be a final document for admins, with relevant information for admins.