vikunja
/
vikunja
6
43
Fork 69
Code Issues 152 Pull Requests 10 Packages Releases 32 Activity

Improved account deletion email grammar #1006

Merged
konrad merged 2 commits from :main into main 2021-10-16 21:53:34 +00:00
Conversation 0 Commits 2 Files Changed 1 +8 -2
Ghost commented 2021-10-16 21:15:54 +00:00
First-time contributor
Copy Link

Description

Change the wording of the account deletion email so that it won't say "Your account will be deleted in 1 days"

Checklist

  • I added or improved tests
  • I added or improved docs for my feature
    • Swagger (including mage do-the-swag)
    • Error codes
    • New config options (including adding them to config.yml.saml and running mage generate-docs)
# Description Change the wording of the account deletion email so that it won't say "Your account will be deleted in 1 days" # Checklist * [ ] I added or improved tests * [ ] I added or improved docs for my feature * [ ] Swagger (including `mage do-the-swag`) * [ ] Error codes * [ ] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)
Ghost added 1 commit 2021-10-16 21:15:55 +00:00
continuous-integration/drone/pr Build is passing Details
f34b7954ad
Improved account deletion grammar
konrad reviewed 2021-10-16 21:17:06 +00:00
pkg/user/notifications.go
@ -230,0 +231,4 @@
dayString := "days"
if n.NotificationNumber == 1 {
dayString = "day"
konrad commented 2021-10-16 21:17:06 +00:00
Owner
Copy Link

Maybe it makes sense to change this to "tomorrow" instead?

Maybe it makes sense to change this to "tomorrow" instead?
Ghost marked this conversation as resolved
Ghost added 1 commit 2021-10-16 21:29:56 +00:00
continuous-integration/drone/pr Build is passing Details
99c2e30462
"Tomorrow" instead of "in 1 days"
konrad approved these changes 2021-10-16 21:30:56 +00:00
konrad approved these changes 2021-10-16 21:52:58 +00:00
konrad left a comment
Owner
Copy Link

Thanks!

Thanks!
konrad merged commit dcb52c00f1 into main 2021-10-16 21:53:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
konrad
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1006
No description provided.
Delete Branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?