Auto-create logs-directory #1213

New Issue

xeruf · 2022-07-18T12:26:46Z

xeruf commented

2022-07-18 12:26:46 +00:00

Enabled file logs, got this:

2022-07-18T12:24:46.897281143Z: CRITICAL	▶ log/GetLogWriter 001 Could not create logfile /app/vikunja/logs/database.log: open /app/vikunja/logs/database.log: no such file or directory

I am expecting the default directory to work ;)

Enabled file logs, got this: 2022-07-18T12:24:46.897281143Z: CRITICAL ▶ log/GetLogWriter 001 Could not create logfile /app/vikunja/logs/database.log: open /app/vikunja/logs/database.log: no such file or directory I am expecting the default directory to work ;)

konrad added the

kind/feature

label 2022-07-18 13:27:12 +00:00

HoffmannP commented

2023-09-26 14:14:59 +00:00

Is this an issue due to os.MkDir instead of os.MkDirAll ?
the log directory should be autocreated.

Is this an issue due to `os.MkDir` instead of `os.MkDirAll` ? the log directory should be autocreated.

konrad commented

2023-09-27 08:08:30 +00:00

I think we don't create the directory at all.

PRs welcome!

I think we don't create the directory at all. PRs welcome!

HoffmannP commented

2023-09-27 10:01:42 +00:00

Yes, the directory is created at f065dcf4ad/pkg/log/logging.go (L60)
but as I said, it should better be MkdirAll. I ~~will add~~ added this to my PR #1606 concerning the log package.

Yes, the directory is created at https://kolaente.dev/vikunja/api/src/commit/f065dcf4adf5bdc54810cac6529506c3e8732366/pkg/log/logging.go#L60 but as I said, it should better be `MkdirAll`. I ~~will add~~ added this to my PR #1606 concerning the log package.

konrad closed this issue

2023-10-10 13:40:13 +00:00

konrad referenced this issue from a commit

2024-02-07 14:00:30 +00:00

chore(deps): update dependency eslint to v8.5.0 (#1213)

Sign in to join this conversation.