Day abbreviations are deleted from regular words #1223

New Issue

rocketfuelindustries · 2022-07-28T09:32:58Z

rocketfuelindustries commented

2022-07-28 09:32:58 +00:00

Version information:

Frontend Version: 0.18.2
API Version: 0.18.1
Browser and OS Version:

Vivaldi 5.3.2679.70 (Stable channel) stable (64-bit) on Kubuntu 22.04 LTS x86_64 (fully updated yesterday)
Firefox 103.0 (64-bit) on Kubuntu 22.04 LTS x86_64 (fully updated yesterday)
Firefox 103.0 (64-bit) on Windows Server 2012 R2
Vikunja api and frontend running on docker on Ubuntu 22.04 from docker hub vikunja/api and vikunja/frontend respectively via docker-compose (with no tag)
database is mariadb, linuxserver.io docker image

Steps to reproduce:

Add a new task with a word starting with "mon", "tue", ..., "sun" in it e.g. "fix monitor stand" and hit Enter or click +ADD

Expected behavior:

A new task is created with the typed word e.g. "fix monitor stand"

Actual behavior:

A new task is created with day prefix removed from the word e.g. "fix monitor stand" becomes "fix itor stand" and the task is due on the day with the prefix e.g. the "fix itor stand" task is due on Monday
"order wedding cake" becomes "order ding cake"
"investigate thumping noise" becomes "investigate mping noise"
"iron frilly napkins" becomes "iron lly napkins"
"take photo of saturn" becomes "take photo of urn"
"fix sunglasses" becomes "fix glasses"
"buy shoes on monday" becomes "buy shoes on day"

Info

Words with leading day abbreviations are not changed anywhere else on either computer, not on other websites in the same browser, typed in the console, in other apps
Behaves as expected if the "mon" word is the first word e.g. "monitor blood pressure" is added as typed
Behaves as expected if the abbreviation is written with a leading uppercase letter e.g. "Monitor" is "Monitor", regardless of position in sentence
Behaves as expected if e.g. "Monitor" is written with any combination of the first 3 letters M, O, N are in uppercase, regardless of position in sentence
removes day abbreviation from word if mixed-case but the first 3 letters are lowercase e.g. moniTor becomes "iTor"
Does not happen on https://try.vikunja.io/ using same browsers, in the same sessions
Does not happen if the abbreviation is inside a word e.g. "buy almonds" is added as typed
Seems similar to vikunja/api#922 but that was inside words, not at the start of words

Checklist:

I have provided all required information
I am using the latest release
I was able to reproduce the bug on try

**Version information:** Frontend Version: 0.18.2 API Version: 0.18.1 Browser and OS Version: - Vivaldi 5.3.2679.70 (Stable channel) stable (64-bit) on Kubuntu 22.04 LTS x86_64 (fully updated yesterday) - Firefox 103.0 (64-bit) on Kubuntu 22.04 LTS x86_64 (fully updated yesterday) - Firefox 103.0 (64-bit) on Windows Server 2012 R2 - Vikunja api and frontend running on docker on Ubuntu 22.04 from docker hub vikunja/api and vikunja/frontend respectively via docker-compose (with no tag) - database is mariadb, linuxserver.io docker image **Steps to reproduce:** 1. Add a new task with a word starting with "mon", "tue", ..., "sun" in it e.g. "fix monitor stand" and hit Enter or click +ADD **Expected behavior:** A new task is created with the typed word e.g. "fix monitor stand" **Actual behavior:** - A new task is created with day prefix removed from the word e.g. "fix monitor stand" becomes "fix itor stand" and the task is due on the day with the prefix e.g. the "fix itor stand" task is due on Monday - "order wedding cake" becomes "order ding cake" - "investigate thumping noise" becomes "investigate mping noise" - "iron frilly napkins" becomes "iron lly napkins" - "take photo of saturn" becomes "take photo of urn" - "fix sunglasses" becomes "fix glasses" - "buy shoes on monday" becomes "buy shoes on day" **Info** - Words with leading day abbreviations are not changed anywhere else on either computer, not on other websites in the same browser, typed in the console, in other apps - Behaves as expected if the "mon" word is the first word e.g. "monitor blood pressure" is added as typed - Behaves as expected if the abbreviation is written with a leading uppercase letter e.g. "Monitor" is "Monitor", regardless of position in sentence - Behaves as expected if e.g. "Monitor" is written with any combination of the first 3 letters M, O, N are in uppercase, regardless of position in sentence - removes day abbreviation from word if mixed-case but the first 3 letters are lowercase e.g. moniTor becomes "iTor" - Does not happen on https://try.vikunja.io/ using same browsers, in the same sessions - Does not happen if the abbreviation is inside a word e.g. "buy almonds" is added as typed - Seems similar to https://kolaente.dev/vikunja/api/issues/922 but that was inside words, not at the start of words **Checklist:** * [x] I have provided all required information * [x] I am using the latest release * [x] I was able to reproduce the bug on [try](https://try.vikunja.io)

rocketfuelindustries commented

2022-07-29 00:23:53 +00:00

[UPDATE 15 hours later] I just tested it again on https://try.vikunja.io/ and the problem was replicated - I added "cook sunday roast" and got "cook day roast". I guess the problem is intermittent because it didn't happen on the try website yesterday

konrad added the

kind/bug

label 2022-07-31 16:07:44 +00:00

konrad referenced this issue from a commit

2022-07-31 16:16:35 +00:00

feat: add more testcases for parsing weekdays

konrad commented

2022-07-31 16:21:28 +00:00

Thanks for the in-depth report!

I plugged your test cases into the test suite which checks the date parser in 518417c0de and was not able to replicate any of the cases you mentioned, neither on try (try always runs the latest release. The latest unstable version has a few changes to the parser, so it is very possible the problem was fixed since the last release. Please reopen this issue if you are able to reliably reproduce this on try (in a private window).

I added "cook sunday roast" and got "cook day roast". I guess the problem is intermittent because it didn't happen on the try website yesterday

This one seems to be added as "cook roast" with a due date next sunday. That's not ideal, but a different issue.

Thanks for the in-depth report! I plugged your test cases into the test suite which checks the date parser in https://kolaente.dev/vikunja/frontend/commit/518417c0de61573d1373cd3eb2ebd1c2d72fbe2b and was not able to replicate any of the cases you mentioned, neither on try (try [always runs the latest release](https://vikunja.io/docs/versions/#unstable). The latest unstable version has a few changes to the parser, so it is very possible the problem was fixed since the last release. Please reopen this issue if you are able to reliably reproduce this on try (in a private window). > I added "cook sunday roast" and got "cook day roast". I guess the problem is intermittent because it didn't happen on the try website yesterday This one seems to be added as "cook roast" with a due date next sunday. That's not ideal, but a different issue.

konrad closed this issue

2022-07-31 16:21:28 +00:00

konrad referenced this issue from a commit

2024-02-07 14:00:30 +00:00

chore(deps): update dependency netlify-cli to v8.2.1 (#1223)

Sign in to join this conversation.