Some settings not getting saved #1250

New Issue

Ghost · 2022-09-10T13:14:40Z

Ghost commented

2022-09-10 13:14:40 +00:00

Version information:

Frontend Version: sha256:4aeda57e0037e9f2db56f5706b7232c4252671657e74d35b9aa65feeac121d0f
API Version: sha256:8b707ff1beebc1c8e61c482a6968d10b5132e83f7fa35d066c15388376790b6b
Browser and OS Version: Firefox (104.0.2) & Windows 10 Version 21H2

Steps to reproduce:

Issue 1
1. Unselect 'Play a sound when marking tasks as done' and press the save button
2. Logout
3. Login
4. 'Play a sound when marking tasks as done' is set back to default
Issue 2
1. Select 'Color Scheme' and press the save button
2. Logout
3. Restart project
4. Login
5. 'Color Scheme' is set back to default
  ...

Expected behavior:
'Color Scheme' and 'Play a sound when marking tasks as done' should be saved

Actual behavior:
'Color Scheme' and 'Play a sound when marking tasks as done' are not saved

How to fix it:
Missing columns in the users table and user_settings.go does not set 'Color Scheme' and 'Play a sound when marking tasks as done'. There might be more settings which are not getting set, I only did notice it on these both.

Checklist:

I have provided all required information
I am using the latest release or the latest unstable build
I was able to reproduce the bug on try

**Version information:** Frontend Version: sha256:4aeda57e0037e9f2db56f5706b7232c4252671657e74d35b9aa65feeac121d0f API Version: sha256:8b707ff1beebc1c8e61c482a6968d10b5132e83f7fa35d066c15388376790b6b Browser and OS Version: Firefox (104.0.2) & Windows 10 Version 21H2 **Steps to reproduce:** 1. Issue 1 1. Unselect 'Play a sound when marking tasks as done' and press the save button 2. Logout 3. Login 4. 'Play a sound when marking tasks as done' is set back to default 2. Issue 2 1. Select 'Color Scheme' and press the save button 2. Logout 3. Restart project 4. Login 5. 'Color Scheme' is set back to default ... **Expected behavior:** 'Color Scheme' and 'Play a sound when marking tasks as done' should be saved **Actual behavior:** 'Color Scheme' and 'Play a sound when marking tasks as done' are not saved **How to fix it:** Missing columns in the users table and [user_settings.go](https://kolaente.dev/vikunja/api/src/branch/main/pkg/routes/api/v1/user_settings.go) does not set 'Color Scheme' and 'Play a sound when marking tasks as done'. There might be more settings which are not getting set, I only did notice it on these both. **Checklist:** * [x] I have provided all required information * [x] I am using the latest release or the latest unstable build * [x] I was able to reproduce the bug on [try](https://try.vikunja.io)

dpschen commented

2022-09-10 13:43:50 +00:00

The settings were saved in localStorage.
Since https://kolaente.dev/vikunja/frontend/commit/51ffe93 they get cleared when you log out since they leaked between users.

Related: vikunja/frontend#2247

As you point out this should be saved in the database.

@konrad:
Not sure if we should add a new column for every simple user setting.
Wouldn't it make more sense to have a field that contains a json to join simple settings? Else we need to adjust api / tables for every small persistent setting.

The settings were saved in localStorage. Since https://kolaente.dev/vikunja/frontend/commit/51ffe93 they get cleared when you log out since they leaked between users. Related: https://kolaente.dev/vikunja/frontend/issues/2247 As you point out this should be saved in the database. @konrad: Not sure if we should add a new column for every simple user setting. Wouldn't it make more sense to have a field that contains a json to join simple settings? Else we need to adjust api / tables for every small persistent setting.

Ghost commented

2022-09-10 14:05:34 +00:00

I see... thanks for the information. I guess I will search for a work around until they found a fitting solution for the issue.

dpschen commented

2022-09-10 14:26:55 +00:00

@WaduLag:
If you are using the app alone on your computer you can check 'Stay logged in' in order to prevent logout and deletion of the localStorage cache.

@WaduLag: If you are using the app alone on your computer you can check 'Stay logged in' in order to prevent logout and deletion of the `localStorage` cache.

konrad commented

2022-09-13 13:30:33 +00:00

Not sure if we should add a new column for every simple user setting.
Wouldn't it make more sense to have a field that contains a json to join simple settings? Else we need to adjust api / tables for every small persistent setting.

Yes. I think we should add a json field to the db for all settings that are exclusive for the frontend.

> Not sure if we should add a new column for every simple user setting. Wouldn't it make more sense to have a field that contains a json to join simple settings? Else we need to adjust api / tables for every small persistent setting. Yes. I think we should add a json field to the db for all settings that are exclusive for the frontend.

🎉 1

dpschen commented

2023-04-01 14:07:26 +00:00

See: vikunja/api#1452

@konrad I guess this issue is done

See: https://kolaente.dev/vikunja/api/issues/1452 @konrad I guess this issue is done

konrad closed this issue

2023-04-01 14:22:05 +00:00

konrad referenced this issue from vikunja/frontend

2023-06-12 14:26:22 +00:00

feat(user): persist frontend settings in the api #3594

konrad referenced this issue from a commit