Some settings not getting saved
Openopened 7 months ago by WaduLag · 4 comments
Reference in New Issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Frontend Version: sha256:4aeda57e0037e9f2db56f5706b7232c4252671657e74d35b9aa65feeac121d0f
API Version: sha256:8b707ff1beebc1c8e61c482a6968d10b5132e83f7fa35d066c15388376790b6b
Browser and OS Version: Firefox (104.0.2) & Windows 10 Version 21H2
Steps to reproduce:
'Color Scheme' and 'Play a sound when marking tasks as done' should be saved
'Color Scheme' and 'Play a sound when marking tasks as done' are not saved
How to fix it:
Missing columns in the users table and user_settings.go does not set 'Color Scheme' and 'Play a sound when marking tasks as done'. There might be more settings which are not getting set, I only did notice it on these both.
The settings were saved in localStorage.
Since https://kolaente.dev/vikunja/frontend/commit/51ffe93 they get cleared when you log out since they leaked between users.
As you point out this should be saved in the database.
Not sure if we should add a new column for every simple user setting.
Wouldn't it make more sense to have a field that contains a json to join simple settings? Else we need to adjust api / tables for every small persistent setting.
I see... thanks for the information. I guess I will search for a work around until they found a fitting solution for the issue.
If you are using the app alone on your computer you can check 'Stay logged in' in order to prevent logout and deletion of the
Yes. I think we should add a json field to the db for all settings that are exclusive for the frontend.