fix(mail): pass mail server timeout #1253

LucaBernstein · 2022-09-24T18:22:02Z

LucaBernstein commented

2022-09-24 18:22:02 +00:00

Description

Fix error log for mailserver closing logic, as default timeout of 15 seconds of mail client package used triggers before our logic leading to error on close.

Also, see issue on GitHub: https://github.com/go-vikunja/api/issues/48

Checklist

~~I added or improved tests~~
~~I added or improved docs for my feature~~
- ~~Swagger (including mage do-the-swag)~~
- ~~Error codes~~
- ~~New config options (including adding them to config.yml.saml and running mage generate-docs)~~

# Description Fix error log for mailserver closing logic, as default timeout of 15 seconds of mail client package used triggers before our logic leading to error on close. Also, see issue on GitHub: https://github.com/go-vikunja/api/issues/48 # Checklist * [ ] ~~I added or improved tests~~ * [ ] ~~I added or improved docs for my feature~~ * [ ] ~~Swagger (including `mage do-the-swag`)~~ * [ ] ~~Error codes~~ * [ ] ~~New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)~~

LucaBernstein force-pushed fix-mail-server-connection-close-error from 3d78f18df4 to 5fb209b8e6

2022-09-26 13:03:32 +00:00

Compare

konrad approved these changes 2022-09-26 15:57:16 +00:00

konrad left a comment

Thanks!

Should be good to merge once the CI passes.

Thanks! Should be good to merge once the CI passes.

konrad scheduled this pull request to auto merge when all checks succeed 2022-09-26 15:57:36 +00:00

konrad merged commit 25609db567 into main

2022-09-26 16:09:45 +00:00

konrad referenced this issue from a commit