vikunja
/
vikunja
6
43
Fork 69
Code Issues 152 Pull Requests 10 Packages Releases 32 Activity

Refactored Dockerfile #1375

Merged
konrad merged 6 commits from vlasov-y/api:main into main 2023-01-31 16:16:22 +00:00
Conversation 0 Commits 6 Files Changed 3 +37 -41
vlasov-y commented 2023-01-27 17:47:39 +00:00
Member
Copy Link
  • Removed VIKUNJA_VERSION and custom git checkout, because it is not found in the repository. So it is not used anywhere.
  • Optimized runner commands order
  • Removed run.sh (it is not needed in fact)
- Removed VIKUNJA_VERSION and custom git checkout, because it is not found in the repository. So it is not used anywhere. - Optimized runner commands order - Removed run.sh (it is not needed in fact)
vlasov-y added 1 commit 2023-01-27 17:47:40 +00:00
continuous-integration/drone/pr Build is failing Details
aaaa50a75a Refactored Dockerfile
vlasov-y added 1 commit 2023-01-27 17:49:12 +00:00
continuous-integration/drone/pr Build is failing Details
d23f9190c3 Nothing special. Just regular commit.
konrad requested changes 2023-01-29 14:49:45 +00:00
Dockerfile Outdated
@ -51,1 +33,3 @@
EXPOSE 3456
RUN apk --update --no-cache add tzdata && \
addgroup -g 1000 vikunja && \
adduser -s /bin/sh -D -G vikunja -u 1000 vikunja -h /app/vikunja -H && \
konrad commented 2023-01-29 14:49:34 +00:00
Owner
Copy Link

The uid and gid of the Vikunja user has to be adjustable at runtime to avoid permission problems with the sqlite db (if used) or file uploads. That's what the script was used for.

The uid and gid of the Vikunja user has to be adjustable at runtime to avoid permission problems with the sqlite db (if used) or file uploads. That's what the script was used for.
vlasov-y commented 2023-01-30 07:01:26 +00:00
Author
Member
Copy Link

a, okay, will do

a, okay, will do
👍 1
vlasov-y commented 2023-01-30 07:39:01 +00:00
Author
Member
Copy Link

Done. I have created an entrypoint script back and run it using tini. Now user creation can be controlled with env variables, which are set to 1000:1000 by default, but can be overridden during the runtime

Done. I have created an entrypoint script back and run it using [tini](https://github.com/krallin/tini). Now user creation can be controlled with env variables, which are set to 1000:1000 by default, but can be overridden during the runtime
vlasov-y added 1 commit 2023-01-30 07:36:45 +00:00
continuous-integration/drone/pr Build is passing Details
eb9b1b47fc Creation of user in the runtime. 
Added tini
vlasov-y requested review from konrad 2023-01-30 07:37:53 +00:00
vlasov-y added 1 commit 2023-01-30 11:20:40 +00:00
continuous-integration/drone/pr Build is passing Details
92cf9b9341 Merge branch 'main' into main
konrad reviewed 2023-01-30 21:35:55 +00:00
Dockerfile Outdated
@ -30,2 +31,3 @@
COPY --from=build-env /build/vikunja-* vikunja
ENV VIKUNJA_SERVICE_ROOTPATH=/app/vikunja/
ENV VIKUNJA_PUID 1000
ENV VIKUNJA_PGID 1000
konrad commented 2023-01-30 21:35:55 +00:00
Owner
Copy Link

Can you rename these to just PUID and PGID? As documented here: https://vikunja.io/docs/install-backend/#setting-user-and-group-id-of-the-user-running-vikunja

Can you rename these to just `PUID` and `PGID`? As documented here: https://vikunja.io/docs/install-backend/#setting-user-and-group-id-of-the-user-running-vikunja
vlasov-y commented 2023-01-31 07:10:01 +00:00
Author
Member
Copy Link

Okay

Okay
vlasov-y commented 2023-01-31 07:12:04 +00:00
Author
Member
Copy Link

Done, please check

Done, please check
vlasov-y added 2 commits 2023-01-31 07:11:52 +00:00
konrad reviewed 2023-01-31 16:15:55 +00:00
konrad left a comment
Owner
Copy Link

Thanks!

Thanks!
konrad merged commit 522bf7d2fc into main 2023-01-31 16:16:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
konrad
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1375
No description provided.
Delete Branch "vlasov-y/api:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?