feat(background): add Last-Modified header #1376
No reviewers
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1376
Loading…
Reference in New Issue
No description provided.
Delete Branch ":last-modified"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add Last-Modified header to background responses so clients can cache the images.
Test Plan:
After this change, open a bunch of different lists with backgrounds and check that the images are being loaded from cache and that Last-Modified header is present (see screenshot).
@ -306,6 +306,11 @@ func GetListBackground(c echo.Context) error {
return handler.HandleHTTPError(err, c)
}
stat, err := bgFile.File.Stat()
Please handle the error - at least log it if it is not critical.
Seems to work great otherwise!
ba622745ce
to584b436c0e
Please fix the lint: https://drone.kolaente.de/vikunja/api/4655/1/11
What's wrong with that lint though? Doesn't seem like anything related to the file this commit is changing
whoops looks like this is broken in main right now. I've just fixed it, please rebase.
584b436c0e
to6d63e4525c
Still wip?
WIP: feat(background): add Last-Modified headerto feat(background): add Last-Modified headerThanks!