vikunja
/
api
5
32
Fork 43
Code Issues 41 Pull Requests 14 Packages Releases 27 Activity
Labels Milestones
New Issue

Multiple labels with same title (importing via CalDav) #1435

Open
opened 5 days ago by ce72 · 0 comments
ce72 commented 5 days ago

Description

Importing CalDav Categories seems to always create new labels, even if a label with the same title exists already for the current user.

Maybe (but I am not very sure) the reason labels from CalDAv are replicated is in https://kolaente.dev/vikunja/api/src/branch/main/pkg/routes/caldav/listStorageProvider.go#L420. labels that are returned from vTask.Update() don't have their id filled in. So comparing by ids cannot work.

But why should we have the same label title multiple times at all?

Vikunja Frontend Version

vikunja/frontend:0.20.5

Vikunja API Version

vikunja/api:0.20.4

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description Importing CalDav Categories seems to always create new labels, even if a label with the same title exists already for the current user. Maybe (but I am not very sure) the reason labels from CalDAv are replicated is in https://kolaente.dev/vikunja/api/src/branch/main/pkg/routes/caldav/listStorageProvider.go#L420. labels that are returned from `vTask.Update()` don't have their id filled in. So comparing by ids cannot work. But why should we have the same label title multiple times at all? ### Vikunja Frontend Version vikunja/frontend:0.20.5 ### Vikunja API Version vikunja/api:0.20.4 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
ce72 added the kind/bug label 5 days ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
renovate/goreleaser-nfpm-2.x
renovate/github.com-wneessen-go-mail-0.x
feature/namespaces-be-gone
renovate/golang-1.x
renovate/github.com-threedotslabs-watermill-1.x
renovate/alpine-3.x
release/0.20
renovate/postgres-15.x
release/0.17
release/0.16
release/0.15
release/0.14
release/0.13
Labels
Apply labels
Clear labels
dependencies duplicate
This issue or pull request already exists help wanted
Need some help invalid
Something is wrong kind/bug
Something is not working kind/feature
New feature needs reproduction question
More information is needed security wontfix
This won't be fixed
No Label dependencies duplicate help wanted invalid kind/bug kind/feature needs reproduction question security wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/api#1435
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes