login endpoint returns 412 error code even if totp is disabled #1518

New Issue

benimautner · 2023-05-10T20:06:27Z

benimautner commented

2023-05-10 20:06:27 +00:00

Description

/login returns http status code 412 when username or password is wrong, which, according to the docs, is reserved for missing or invalid totp code.

Vikunja Frontend Version

v0.20.5

Vikunja API Version

v0.20.4

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description /login returns http status code 412 when username or password is wrong, which, according to the docs, is reserved for missing or invalid totp code. ### Vikunja Frontend Version v0.20.5 ### Vikunja API Version v0.20.4 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_

image.png

7.3 KiB

benimautner added the

kind/bug

label 2023-05-10 20:06:27 +00:00

konrad commented

2023-05-10 20:09:59 +00:00

You mean the status code? That can be a few different errors. You should check Vikunja's error code: https://vikunja.io/docs/errors/#user

For wrong username or password that's 1011, for an invalid totp code that's 1017.

You mean the status code? That can be a few different errors. You should check Vikunja's error code: https://vikunja.io/docs/errors/#user For wrong username or password that's 1011, for an invalid totp code that's 1017.

benimautner commented

2023-05-10 20:47:07 +00:00

I was talking about the http response code, which, according to the docs, should be 403 for wrong username or password instead of 412.
I am using the ErrorCode now. I was just confused because the api docs say something different.
https://try.vikunja.io/api/v1/docs#tag/user/paths/~1login/post

I was talking about the http response code, which, according to the docs, should be 403 for wrong username or password instead of 412. I am using the ErrorCode now. I was just confused because the api docs say something different. https://try.vikunja.io/api/v1/docs#tag/user/paths/~1login/post

konrad commented

2023-05-11 11:03:02 +00:00

Yeah the docs need an update.

konrad commented

2023-05-11 20:26:40 +00:00

Turns out swagger (or the lib we're using to generate swagger docs) only allows one response per http status code. That kind of prevents us from using multiple responses. I'll add a note to the docs.

konrad referenced this issue from a commit

2023-05-30 19:37:45 +00:00

fix(docs): clarify error codes in swagger docs

konrad closed this issue

2023-05-30 19:37:45 +00:00

Sign in to join this conversation.