List Backgrounds #568

Merged

konrad merged 27 commits from list-backgrounds into master 2020-05-26 20:07:57 +00:00

Conversation 0 Commits 27 Files Changed 18 +720 -57

konrad commented 2020-05-25 21:00:18 +00:00

Owner

Copy Link

Description

This PR adds a rather abstract list background implementation to the api.
For now, only unsplash is supported, uploading own images will be introduced in another pr.

To do

• Remove the last file + unsplash info if a background is updated
• Make application ID configurable (+ docs)
• Return background info when loading a list
• Rights
• Check a list exists prior to setting a background

Checklist

• Lint issues
• I added or improved tests
• I added or improved docs for my feature
  • Swagger (including make do-the-swag)
  • New config options

# Description This PR adds a rather abstract list background implementation to the api. For now, only unsplash is supported, uploading own images will be introduced in another pr. ### To do * [x] Remove the last file + unsplash info if a background is updated * [x] Make application ID configurable (+ docs) * [x] Return background info when loading a list * [x] Rights * [x] Check a list exists prior to setting a background # Checklist * [x] Lint issues * [x] I added or improved tests * [x] I added or improved docs for my feature * [x] Swagger (including `make do-the-swag`) * [x] New config options

konrad referenced this issue from a commit 2020-05-26 20:07:56 +00:00

List Backgrounds (#568) Return the updated list when setting a list background Add swagger docs for unsplash methods Add unsplash info to search results Fix misspell Fix lint Add rights check for setting and getting backgrounds Show unsplash information when loading a single list Make application id for pingbacks configurable Remove old backgrounds when setting a new one Return 404 if the list does not have a background Implement getting list backgrounds Implement actually setting a photo from unsplash as list background go mod tidy Add migration for background file id Roughly implement setting a list background from unsplash Implement saving a background Add migration for unsplash photo table Add unsplash search Fix parsing page param Fix parsing page param Fix background config Add unsplash wrapper library Add enabled background providers to info endpoint Add config options for backgrounds Add unsplash background provider Add routing handler for backgrounds Add basic background provider interface Co-authored-by: kolaente <k@knt.li> Reviewed-on: https://kolaente.dev/vikunja/api/pulls/568

konrad merged commit e5e30d0915 into master 2020-05-26 20:07:57 +00:00

konrad deleted branch list-backgrounds 2020-05-26 20:08:01 +00:00

konrad referenced this issue from a commit 2024-02-07 14:00:26 +00:00

Update dependency wait-on to v6 (#568)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

dependencies

  

duplicate

This issue or pull request already exists

  

help wanted

Need some help

  

invalid

Something is wrong

  

kind/bug

Something is not working

  

kind/feature

New feature

  

needs reproduction

  

question

More information is needed

  

security

  

wontfix

This won't be fixed

No Label

dependencies

duplicate

help wanted

invalid

kind/bug

kind/feature

needs reproduction

question

security

wontfix

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#568

No description provided.