Fix completion status in DAV for OpenTasks and multiline descriptions #697

freaktechnik · 2020-10-21T20:13:56Z

freaktechnik commented

2020-10-21 20:13:56 +00:00

Description

This fixes the completion state of tasks in OpenTasks not working correctly. It also fixes multiline descriptions, since newlines are reserved in iCal for new properties (unless you indent with two spaces, which is for formatting because 80 chars wide is way better or something).

Checklist

I added or improved tests
I added or improved docs for my feature
- Swagger (including mage do-the-swag)
- Error codes
- New config options (including adding them to config.yml.saml and running mage generate-docs)

# Description This fixes the completion state of tasks in OpenTasks not working correctly. It also fixes multiline descriptions, since newlines are reserved in iCal for new properties (unless you indent with two spaces, which is for formatting because 80 chars wide is way better or something). # Checklist * [x] I added or improved tests * [ ] I added or improved docs for my feature * [ ] Swagger (including `mage do-the-swag`) * [ ] Error codes * [ ] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)

freaktechnik added 2 commits 2020-10-21 20:13:58 +00:00

0e3a6cd673

Fix caldav task complete status for OpenTasks

continuous-integration/drone/pr Build is passing Details

319cdbfc87

fix caldav descriptions

konrad reviewed 2020-10-21 20:28:27 +00:00

konrad left a comment

Looks great! Could you add a test for this behaviour?

freaktechnik added 1 commit 2020-10-21 20:50:19 +00:00