Frontendurl should contain a / at the end // Link to task in notification email missing slash between domain and path #876

Closed
opened 2021-05-28 03:59:04 +00:00 by SteveDinn · 2 comments

I have just set up notification emails for Vikunja. I got my first one and clicked on the link but the URL is not valid. It was missing a slash between the domain and the path part of the URL.

eg. https://vikunja.example.comtasks/26

obviously, the link above should read https://vikunja.example.com/tasks/26

I have just set up notification emails for Vikunja. I got my first one and clicked on the link but the URL is not valid. It was missing a slash between the domain and the path part of the URL. eg. https://vikunja.example.comtasks/26 obviously, the link above should read https://vikunja.example.com/tasks/26
Owner

That link is derived from the frontendurl you've configured in the api. It assumes a / at the end.

I think we could add a function to make sure the url always ends with a / though.
Until then, you should be able to fix this by adding a / to the configured frontend url.

That link is derived from the [frontendurl](https://vikunja.io/docs/config-options/#frontendurl) you've configured in the api. It assumes a `/` at the end. I think we could add a function to make sure the url always ends with a `/` though. Until then, you should be able to fix this by adding a `/` to the configured frontend url.
konrad added the
kind/feature
label 2021-05-28 06:34:06 +00:00
konrad changed title from Link to task in notification email missing slash between domain and path to Frontendurl should contain a / at the end // Link to task in notification email missing slash between domain and path 2021-05-28 06:34:24 +00:00
Owner

Implemented in afd6bde74d

Feel free to reopen if you have issues.

Implemented in https://kolaente.dev/vikunja/api/commit/afd6bde74dd1d0dcaf4f95d73caa4d4bbbf695c9 Feel free to reopen if you have issues.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#876
No description provided.