Add support of Unix socket #912

Merged
konrad merged 1 commits from andreymal/api:main into main 2021-07-08 08:13:02 +00:00
Contributor

This may probably resolve #872, but the limitation is that this implementation doesn't allow both unix and tcp, not sure if @Dave will be happy with this

This may probably resolve #872, but the limitation is that this implementation doesn't allow both unix and tcp, not sure if @Dave will be happy with this
andreymal force-pushed main from 2bba00d132 to d3b79548c1 2021-07-07 22:26:28 +00:00 Compare
First-time contributor

I'm perfectly ok with that, first of all because you provided the code :D and secondly because the entire point of a unix domain socket is to avoid the TCP/IP stack in the first place. See this:

https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets

and look at Peter Green's decently formed answer to this question.

Thank you for this code.

I'm perfectly ok with that, first of all because you provided the code :D and secondly because the entire point of a unix domain socket is to avoid the TCP/IP stack in the first place. See this: https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets and look at Peter Green's decently formed answer to this question. Thank you for this code.
konrad approved these changes 2021-07-08 08:12:20 +00:00
konrad left a comment
Owner

Looks great!

I think we can merge this once the CI passes.

Thanks for the PR.

Looks great! I think we can merge this once the CI passes. Thanks for the PR.
Owner

Ah, looks like the CI passed but not in the commit from before. I'll merge this now.

Ah, looks like the CI passed but not in the commit from before. I'll merge this now.
konrad merged commit 50b49ffab6 into main 2021-07-08 08:13:02 +00:00
First-time contributor

This works as of the git pull I did today. :) Thank you.

This works as of the git pull I did today. :) Thank you.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#912
No description provided.