Make sure list / task favorites are set per user, not per entity #915
No reviewers
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#915
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix/favorites"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
This PR changes the way task/list favorites are saved internally: Previously, each entity had a
is_favorite
field in the db. If a user marked it as favorite, the field would contain true.This has one big issue: Favorites are global - if one user of a shared lists marks that as favorite it is set to be favorite for everyone.
From now on, all favorite state is saved in a separate table and joined together when a user requests a list of lists/tasks.
Resolves vikunja/api#914
Checklist