vikunja
/
vikunja
6
43
Fork 69
Code Issues 152 Pull Requests 10 Packages Releases 32 Activity

Refactor user email confirmation + password reset handling #919

Merged
konrad merged 11 commits from feature/email-confirmation into main 2021-07-13 20:56:02 +00:00
Conversation 0 Commits 11 Files Changed 25 +436 -134
konrad commented 2021-07-13 20:25:02 +00:00
Owner
Copy Link

Description

This PR refactors the way user tokens (password request and email verification) and statuses are handled internally.
It introduces a new table user_token which stores all kinds of tokens and a bunch of helper methods to manage them. This could be expanded further in the future.

It also removes the IsActive boolean field of a user to a more general Status field to better distinguish if a user is disabled or only required to confirm their email address.

Checklist

  • I added or improved tests
# Description This PR refactors the way user tokens (password request and email verification) and statuses are handled internally. It introduces a new table `user_token` which stores all kinds of tokens and a bunch of helper methods to manage them. This could be expanded further in the future. It also removes the `IsActive` boolean field of a user to a more general `Status` field to better distinguish if a user is disabled or only required to confirm their email address. # Checklist * [x] I added or improved tests
konrad added 10 commits 2021-07-13 20:25:03 +00:00
continuous-integration/drone/pr Build is failing Details
80b6e9dd0f
Lint
konrad added 1 commit 2021-07-13 20:50:11 +00:00
continuous-integration/drone/pr Build is passing Details
1195c9b243
Fix token migration for postgres
konrad merged commit 4216ed7277 into main 2021-07-13 20:56:02 +00:00
konrad deleted branch feature/email-confirmation 2021-07-13 20:56:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#919
No description provided.
Delete Branch "feature/email-confirmation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?