Enable a list to be moved across namespaces #1096

Merged
konrad merged 7 commits from shilch/api:feature/move-list into main 10 months ago
Collaborator

Description

Allows a list to be moved across namespaces by accepting a different namespace_id when updating a list. This only changes the backend code; the feature is not yet implemented as a frontend action.
The written unit tests pass but I haven't actually tried the API call yet (thus WIP).

Checklist

  • I added or improved tests
  • I added or improved docs for my feature
    • Swagger (including mage do-the-swag)
    • Error codes
    • New config options (including adding them to config.yml.saml and running mage generate-docs)
# Description Allows a list to be moved across namespaces by accepting a different `namespace_id` when updating a list. This only changes the backend code; the feature is not yet implemented as a frontend action. The written unit tests pass but I haven't actually tried the API call yet (thus WIP). # Checklist * [x] I added or improved tests * [x] I added or improved docs for my feature * [x] Swagger (including `mage do-the-swag`) * [x] Error codes * [x] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)
shilch added 6 commits 10 months ago
22ba82a233
Let mage test:unit generate a coverprofile
eaabad5861
Update swagger docs
konrad requested changes 10 months ago
konrad left a comment
Owner

Very nice, thanks a lot!

Just some small nits, looks fine overall.

Very nice, thanks a lot! Just some small nits, looks fine overall.
pkg/cmd/web.go Outdated
e.Logger.Fatal(err)
}
}
log.Infof("Server is running on %s", config.ServiceInterface.GetString())
Owner

Echo already shows a message like this when the server is started - I feel like this would double it. Also it does not take into account if the server is listening on a socket instead. I would prefer to remove this.

Echo already shows a message like this when the server is started - I feel like this would double it. Also it does not take into account if the server is listening on a socket instead. I would prefer to remove this.
Poster
Collaborator

Reverted

Reverted
konrad marked this conversation as resolved
func init() {
swag.Register(swag.Name, &s{})
swag.Register("swagger", &s{})
Owner

Not quite sure where this is coming from, but probably fine to have. What swag version do you have installed?

Not quite sure where this is coming from, but probably fine to have. What swag version do you have installed?
Poster
Collaborator
swag --version
swag version v1.7.8

Which is the latest one.

``` swag --version swag version v1.7.8 ``` Which is [the latest one](https://github.com/swaggo/swag/releases/tag/v1.7.8).
Owner

I think it should be fine then.

I think it should be fine then.
konrad marked this conversation as resolved
Owner

Just checked with curl and it works without issues.

Just checked with curl and it works without issues.
shilch changed title from WIP: Enable a list to be moved across namespaces to Enable a list to be moved across namespaces 10 months ago
shilch added 1 commit 10 months ago
ce3f3ed687
Revert "Log server listening endpoint on startup"
konrad approved these changes 10 months ago
konrad left a comment
Owner

Looks good, will merge once the pipeline succeeds.

Looks good, will merge once the pipeline succeeds.
konrad merged commit f7a06e4644 into main 10 months ago
konrad deleted branch feature/move-list 10 months ago

Reviewers

konrad approved these changes 10 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as f7a06e4644.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/api#1096
Loading…
There is no content yet.