Add exec to run script to run app as PID 1 #1200

TheEdgeOfRage · 2022-07-12T10:40:26Z

TheEdgeOfRage commented

2022-07-12 10:40:26 +00:00

Description

When running the docker container, the sh script will run as PID 1 and intercept any external signals (like docker stop) and won't pass it on to the app. Docker will wait for 10 seconds before proceeding to force kill the app, leading to both an unclean shutdown and an unnecessary wait of 10 seconds.

The exec in the script replaces the shell process with the su process, which correctly passes on signals to the app process and triggers a regular shutdown when doing a docker stop.

Checklist

I added or improved tests
I added or improved docs for my feature
Swagger (including mage do-the-swag)
Error codes
New config options (including adding them to config.yml.saml and running mage generate-docs)

I don't think any of these apply here, but please let me know if I need to do anything else :)

# Description When running the docker container, the sh script will run as PID 1 and intercept any external signals (like docker stop) and won't pass it on to the app. Docker will wait for 10 seconds before proceeding to force kill the app, leading to both an unclean shutdown and an unnecessary wait of 10 seconds. The exec in the script replaces the shell process with the `su` process, which correctly passes on signals to the app process and triggers a regular shutdown when doing a docker stop. # Checklist * [ ] I added or improved tests * [ ] I added or improved docs for my feature * [ ] Swagger (including `mage do-the-swag`) * [ ] Error codes * [ ] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`) I don't think any of these apply here, but please let me know if I need to do anything else :)

TheEdgeOfRage added 1 commit 2022-07-12 10:40:30 +00:00