vikunja
/
vikunja
6
43
Fork 71
Code Issues 150 Pull Requests 16 Packages Releases 32 Activity

feat: change assignee filter to search by username instead of user id #1237

Merged
konrad merged 4 commits from fix/assignee-search-by-username into main 2022-08-16 21:27:36 +00:00
Conversation 0 Commits 4 Files Changed 7 +242 -17
konrad commented 2022-08-15 18:34:14 +00:00
Owner
Copy Link

Description

This PR changes the filter logic so that it searches for usernames instead of user ids when filtering for assignees.

This is a breaking change.

Partial fix for: https://github.com/go-vikunja/frontend/issues/69

Checklist

  • I added or improved tests
# Description This PR changes the filter logic so that it searches for usernames instead of user ids when filtering for assignees. **This is a breaking change.** Partial fix for: https://github.com/go-vikunja/frontend/issues/69 # Checklist * [x] I added or improved tests
konrad added 2 commits 2022-08-15 18:34:14 +00:00
konrad changed title from fix/assignee-search-by-username to feat: change assignee filter to search by username instead of user id 2022-08-15 18:34:59 +00:00
konrad added 2 commits 2022-08-15 20:41:53 +00:00
continuous-integration/drone/pr Build is passing Details
7d00ccd95f
fix: lint
konrad merged commit 0c8bed4054 into main 2022-08-16 21:27:36 +00:00
konrad deleted branch fix/assignee-search-by-username 2022-08-16 21:27:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1237
No description provided.
Delete Branch "fix/assignee-search-by-username"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?