#1416: Step 1 Rename Reminders to ReminderDates

@@ -335,3 +335,3 @@
 	// To still find tasks with nil values, we exclude 0s when comparing with >/< values.
 	for _, f := range opts.filters {
-		if f.field == "reminders" {
+		if f.field == "ReminderDates" {

@@ -0,0 +24,4 @@
+)
+
+type taskReminders20230307171848 struct {
+	Reminder       time.Time `xorm:"DATETIME not null INDEX 'reminder'" json:"reminder"`

@@ -53,0 +49,4 @@
+			assert.Contains(t, rec.Body.String(), `task #6 `)
+			assert.Contains(t, rec.Body.String(), `task #7 `)
+			assert.Contains(t, rec.Body.String(), `task #8 `)
+			assert.Contains(t, rec.Body.String(), `task #9 `)

@@ -967,2 +980,3 @@
+
 	// Update the reminders
-	if err := t.updateReminders(s, t.Reminders); err != nil {
+	if err := t.updateReminders(s, t.Reminders, t.DueDate, t.StartDate, t.EndDate); err != nil {

@@ -1051,2 +1073,3 @@
+
 	// Update the reminders
-	if err := ot.updateReminders(s, t.Reminders); err != nil {
+	if err := ot.updateReminders(s, t.Reminders, t.DueDate, t.StartDate, t.EndDate); err != nil {

@@ -1481,0 +1523,4 @@
+func updateRelativeReminderDates(reminders []*TaskReminder, dueDate time.Time, startDate time.Time, endDate time.Time) {
+	for _, reminder := range reminders {
+		relativeDuration := time.Duration(reminder.RelativePeriod) * time.Second
+		switch reminder.RelativeTo {

@@ -1494,2 +1557,3 @@
+
 	// Resolve duplicates and sort them
-	reminderMap := make(map[int64]time.Time, len(reminders))
+	reminderMap := make(map[int64]TaskReminder, len(reminders))

@@ -1508,2 +1582,2 @@
-	t.Reminders = reminders
-	if len(reminders) == 0 {
+	// sort reminders
+	sort.Slice(t.Reminders, func(i, j int) bool {

@@ -876,2 +876,4 @@
 }
 
+// ErrReminderRelativeToMissing represents an error where a task has a relative reminder without reference date
+type ErrReminderRelativeToMissing struct {

@@ -1481,0 +1518,4 @@
+			if !task.DueDate.IsZero() {
+				reminder.Reminder = task.DueDate.Add(relativeDuration)
+			} else {
+				reminder.Reminder = time.Time{}

@@ -878,0 +898,4 @@
+	return web.HTTPError{
+		HTTPCode: http.StatusBadRequest,
+		Code:     ErrCodeReminderRelativeToMissing,
+		Message:  "Relative reminder without relative_to",