vikunja
/
vikunja
6
43
Fork 71
Code Issues 150 Pull Requests 15 Packages Releases 32 Activity

WIP: fix(semver): fix produced version number #1472

Closed
dpschen wants to merge 1 commits from dpschen/api:fix-produced-semver-version-number into main
pull from: dpschen/api:fix-produced-semver-version-number
merge into: vikunja:main
Conversation 2 Commits 1 Files Changed 2 +2 -3
dpschen commented 2023-04-05 11:11:59 +00:00
Member
Copy Link

The "+" is not compatible and leads to problems with semver version parsers

Related frontend PR: vikunja/frontend#2929

The "+" is not compatible and leads to problems with semver version parsers Related frontend PR: https://kolaente.dev/vikunja/frontend/pulls/2929
konrad reviewed 2023-04-05 11:14:21 +00:00
magefile.go Outdated
@ -95,3 +95,3 @@
}
VersionNumber = strings.Trim(string(version), "\n")
VersionNumber = strings.Replace(VersionNumber, "-", "+", 1)
// VersionNumber = strings.Replace(VersionNumber, "-", "+", 1)
konrad commented 2023-04-05 11:14:21 +00:00
Owner
Copy Link

Can you remove this line?

Can you remove this line?
konrad commented 2023-04-05 11:14:35 +00:00
Owner
Copy Link

How should we coordinate merging this with the frontend PR?

How should we coordinate merging this with the frontend PR?
dpschen reviewed 2023-04-05 11:40:10 +00:00
docs/content/doc/setup/versions.md Outdated
@ -17,3 +17,3 @@
## Stable
Stable releases have a fixed version number like `0.18.2` and are published at irregular intervals whenever a new version is ready.
Stable releases have a fixed version number like `0.20.2` and are published at irregular intervals whenever a new version is ready.
dpschen commented 2023-04-05 11:40:10 +00:00
Author
Member
Copy Link

@konrad How could we render the current version dynamically here?

@konrad How could we render the current version dynamically here?
konrad commented 2023-04-05 11:51:41 +00:00
Owner
Copy Link

Probably with a placeholder string and a ci step doing sed magic.

Probably with a placeholder string and a ci step doing sed magic.
dpschen force-pushed fix-produced-semver-version-number from d7173c9f90 to 23ac9bbb61 2023-04-05 11:42:00 +00:00 Compare
konrad commented 2024-01-16 12:15:59 +00:00
Owner
Copy Link

Closing due to inactivity.

Closing due to inactivity.
konrad closed this pull request 2024-01-16 12:15:59 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1472
No description provided.
Delete Branch "dpschen/api:fix-produced-semver-version-number"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?