vikunja
/
vikunja
6
43
Fork 68
Code Issues 151 Pull Requests 15 Packages Releases 32 Activity

Migrate all timestamps to real iso dates #594

Merged
konrad merged 50 commits from feature/datetime into master 2020-06-27 17:04:18 +00:00
Conversation 0 Commits 50 Files Changed 83 +2208 -1257
konrad commented 2020-06-21 21:22:53 +00:00
Owner
Copy Link

Description

Currently, unix timestamps are used everywhere. These should be real iso timestamps, not those fake timeutil.Timestamp stuff.

Todo

  • Better error messages for failed migration steps to tell about what went wrong
  • Migrations for sqlite
  • Change the names of _unix fields in structs
    • Remove suffix adding hacks in filters and such
  • Change definitions to use time.Time everywhere instead of the hacky timestamp thingy
  • Remove timeutil
  • Make sure all tests still pass
# Description Currently, unix timestamps are used everywhere. These should be real iso timestamps, not those fake `timeutil.Timestamp` stuff. # Todo * [x] Better error messages for failed migration steps to tell about what went wrong * [x] Migrations for sqlite * [x] Change the names of `_unix` fields in structs * [x] Remove suffix adding hacks in filters and such * [x] Change definitions to use `time.Time` everywhere instead of the hacky timestamp thingy * [x] Remove timeutil * [x] Make sure all tests still pass
konrad added 3 commits 2020-06-21 21:22:53 +00:00
continuous-integration/drone/pr Build is failing Details
46003efc50
Fix sql statement for mysql
konrad added 3 commits 2020-06-22 19:38:06 +00:00
continuous-integration/drone/pr Build is failing Details
c91a791a4d
Merge branch 'master' into feature/datetime
konrad added 1 commit 2020-06-22 19:56:41 +00:00
continuous-integration/drone/pr Build was killed Details
78757162ab
Add all tables and columns for migration
konrad added 2 commits 2020-06-22 20:20:31 +00:00
continuous-integration/drone/pr Build was killed Details
f45ed9453d
Convert 0 to null in timestamps
konrad added 3 commits 2020-06-22 20:57:43 +00:00
continuous-integration/drone/pr Build is failing Details
d9ba8b96c2
SQLite stub
konrad added 1 commit 2020-06-23 21:26:31 +00:00
continuous-integration/drone/pr Build was killed Details
e3e27ab94b
Add migration script for sqlite
konrad added 1 commit 2020-06-23 21:36:07 +00:00
konrad added 1 commit 2020-06-23 21:38:21 +00:00
continuous-integration/drone/pr Build is failing Details
11df4b85e8
Add better error messages when running migrations
konrad added 5 commits 2020-06-25 15:39:15 +00:00
continuous-integration/drone/push Build is passing Details
f2025c2658
Fix sqlite path in default config
continuous-integration/drone/push Build is passing Details
7b31301f09 Update golang.org/x/crypto commit hash to 75b2880 (#596) 
Update golang.org/x/crypto commit hash to 75b2880

Reviewed-on: vikunja/api#596
continuous-integration/drone/push Build is passing Details
caee123f9d
Add better errors if the sqlite db file is not writable
continuous-integration/drone/push Build is failing Details
c8605d6b3d
Enable upload backgrounds by default
continuous-integration/drone/pr Build is failing Details
6ef4a915b1
Merge branch 'master' into feature/datetime
konrad added 1 commit 2020-06-25 22:08:54 +00:00
continuous-integration/drone/pr Build is failing Details
0443863b8b
Merge branch 'master' into feature/datetime
konrad added 1 commit 2020-06-25 22:39:43 +00:00
continuous-integration/drone/pr Build is failing Details
ff152e4d0d
Merge branch 'master' into feature/datetime
konrad added 4 commits 2020-06-26 15:36:20 +00:00
continuous-integration/drone/pr Build is failing Details
13e17c2ee8
Remove adding _unix suffix hack
konrad added 1 commit 2020-06-26 15:37:49 +00:00
continuous-integration/drone/pr Build is failing Details
65ec94786a
Remove timeutil package
konrad added 1 commit 2020-06-26 16:36:44 +00:00
continuous-integration/drone/pr Build was killed Details
09c9780bb9
Partially fix tests
konrad added 3 commits 2020-06-26 17:49:12 +00:00
continuous-integration/drone/pr Build was killed Details
9137c549d2
Fix misspell
konrad added 1 commit 2020-06-26 17:55:39 +00:00
continuous-integration/drone/pr Build was killed Details
831242c4ff
Fix test fixtures
konrad added 1 commit 2020-06-26 17:59:26 +00:00
continuous-integration/drone/pr Build is failing Details
6ae9ea3bee
Fix lint
konrad added 1 commit 2020-06-26 20:27:28 +00:00
continuous-integration/drone/pr Build is failing Details
d55e9f5d9a
Set created and updated timestamps for all fixtures
konrad added 2 commits 2020-06-26 22:27:29 +00:00
continuous-integration/drone/pr Build is failing Details
58e044bb36
Change fixtures time zone to gmt
konrad added 1 commit 2020-06-26 22:48:34 +00:00
continuous-integration/drone/pr Build is failing Details
85babcbbb3
Properly set timezone
konrad added 1 commit 2020-06-27 10:38:43 +00:00
continuous-integration/drone/pr Build is failing Details
4853fc7824
Fix tests and fixtures for date timezone stuff
konrad added 2 commits 2020-06-27 11:05:15 +00:00
continuous-integration/drone/pr Build is failing Details
a65e2e15b5
Fix task filter
konrad added 2 commits 2020-06-27 11:26:07 +00:00
continuous-integration/drone/pr Build was killed Details
139d2a4723
Fix integration tests
konrad added 1 commit 2020-06-27 11:47:39 +00:00
continuous-integration/drone/pr Build is failing Details
d4e0dac28b
Add error and test for invalid filter values
konrad added 2 commits 2020-06-27 13:59:10 +00:00
continuous-integration/drone/pr Build is failing Details
1da298f3fe
Fix caldav reminder parsing
konrad added 2 commits 2020-06-27 14:06:02 +00:00
continuous-integration/drone/pr Build is failing Details
9f670194f2
Fix timezone setting for wunderlist parsing
konrad added 1 commit 2020-06-27 14:19:18 +00:00
continuous-integration/drone/pr Build is failing Details
0eae995316
Fix timezone setting for todoist parsing
konrad added 1 commit 2020-06-27 14:36:47 +00:00
continuous-integration/drone/pr Build was killed Details
12d73063d0
Merge branch 'master' into feature/datetime
konrad added 1 commit 2020-06-27 14:52:51 +00:00
continuous-integration/drone/pr Build is failing Details
0f6fac2e56
Fix null filter
konrad added 1 commit 2020-06-27 15:39:28 +00:00
continuous-integration/drone/pr Build is failing Details
e4bb42b46c
Always set db time to gmt
konrad added 1 commit 2020-06-27 16:10:47 +00:00
continuous-integration/drone/pr Build is failing Details
cc688f0594
Add option to include null results when filtering
konrad added 2 commits 2020-06-27 16:27:37 +00:00
continuous-integration/drone/pr Build is passing Details
f945d6b74a
"fix" gocyclo
konrad merged commit 08205008e7 into master 2020-06-27 17:04:06 +00:00
konrad deleted branch feature/datetime 2020-06-27 17:04:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#594
No description provided.
Delete Branch "feature/datetime"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?