Added section to full-docker-example.md for Caddy v2. #595

Merged
konrad merged 3 commits from leggettc18/api:master into master 2020-06-22 04:48:02 +00:00
Contributor

Description

I added a section to the full-docker-example docs for the Caddy v2 webserver, in case anyone gets stuck on it like I did.

Checklist

  • I added or improved tests
  • I pushed new or updated dependencies to the repo using go mod vendor
  • I added or improved docs for my feature
    • Swagger (including make do-the-swag)
    • Error codes
    • New config options
# Description I added a section to the full-docker-example docs for the Caddy v2 webserver, in case anyone gets stuck on it like I did. # Checklist * [ ] I added or improved tests * [ ] I pushed new or updated dependencies to the repo using `go mod vendor` * [x] I added or improved docs for my feature * [ ] Swagger (including `make do-the-swag`) * [ ] Error codes * [ ] New config options
leggettc18 added 1 commit 2020-06-22 03:38:12 +00:00
continuous-integration/drone/pr Build is failing Details
2859c71253
Added section to full-docker-example.md for Caddy v2.
konrad requested changes 2020-06-22 03:46:13 +00:00
konrad left a comment
Owner

Two small nits, looking good otherwise!

Two small nits, looking good otherwise!
@ -221,0 +260,4 @@
frontend:
image: vikunja/frontend
restart: unless-stopped
proxy:
Owner

I guess you would not need the nginx proxy when using caddy? Could you remove that?

I guess you would not need the nginx proxy when using caddy? Could you remove that?
leggettc18 marked this conversation as resolved
@ -221,0 +270,4 @@
- api
- frontend
restart: unless-stopped
caddy:
Owner

Please also add a depends_on section like the proxy has.

Please also add a `depends_on` section like the proxy has.
Author
Contributor

Yup I copy pasted the proxy docker-compose because it ended up being exactly the same minus the proxy section which I just forgot to remove. Oops! Gimme a few minutes I'll get that cleaned up.

Yup I copy pasted the proxy docker-compose because it ended up being exactly the same minus the proxy section which I just forgot to remove. Oops! Gimme a few minutes I'll get that cleaned up.
leggettc18 added 1 commit 2020-06-22 03:52:07 +00:00
continuous-integration/drone/pr Build is passing Details
c6980a390f
Fixed some leftovers from copy-paste.
leggettc18 added 1 commit 2020-06-22 03:53:15 +00:00
continuous-integration/drone/pr Build is passing Details
5b0628233d
Fixed one more leftover formatting oddity.
Author
Contributor

Ok those should be fixed now.

Ok those should be fixed now.
leggettc18 requested review from konrad 2020-06-22 04:07:34 +00:00
konrad approved these changes 2020-06-22 04:10:04 +00:00
konrad left a comment
Owner

Looks good now, I'll merge once ci passes.

Looks good now, I'll merge once ci passes.
konrad merged commit 8b030135de into master 2020-06-22 04:48:01 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#595
No description provided.