fetch tasks for caldav lists #641

freaktechnik · 2020-08-23T21:29:25Z

freaktechnik commented

2020-08-23 21:29:25 +00:00

Description

This is just the part that fixed the issue with caldav returning empty responses due to lists not having tasks anymore.

Somehow the vscode go plugin insists on re-organizing the imports, too. I'm not familiar enough with go and its ecosystem to understand what's going on there.

Checklist

I added or improved tests
I added or improved docs for my feature
- Swagger (including make do-the-swag)
- Error codes
- New config options

# Description This is just the part that fixed the issue with caldav returning empty responses due to lists not having tasks anymore. Somehow the vscode go plugin insists on re-organizing the imports, too. I'm not familiar enough with go and its ecosystem to understand what's going on there. # Checklist * [ ] I added or improved tests * [ ] I added or improved docs for my feature * [ ] Swagger (including `make do-the-swag`) * [ ] Error codes * [ ] New config options

freaktechnik added 1 commit 2020-08-23 21:29:28 +00:00

continuous-integration/drone/pr Build is passing Details

464e539897

fetch tasks for caldav lists

konrad commented

2020-08-24 18:56:47 +00:00

There seems to be an issue with the build server, I hope to fix that soon.

konrad requested changes 2020-08-24 19:55:56 +00:00

konrad left a comment

Looks great so far, thanks!

Could you add a test?

Looks great so far, thanks! Could you add a test?

pkg/routes/caldav/listStorageProvider.go Outdated

						
				@ -399,0 +409,4 @@

							return

						}

						tasks, ok := iface.([]*models.Task)

						if ok {

konrad commented

2020-08-24 19:55:14 +00:00

By design, this should always be true, if it isn't something is wrong with the implementation. Could you add a panic in that case? (In an else) That way it would be catched in the tests if it fails.

By design, this should always be true, if it isn't something is wrong with the implementation. Could you add a `panic` in that case? (In an `else`) That way it would be catched in the tests if it fails.

konrad commented

2020-10-17 20:09:00 +00:00

Done.

konrad marked this conversation as resolved

konrad commented

2020-08-24 19:56:48 +00:00

Somehow the vscode go plugin insists on re-organizing the imports, too. I'm not familiar enough with go and its ecosystem to understand what's going on there.

That's fine - it is a best-practice to do this which I've yet to add a linter for in the pipeline (I plan on doing this while reorganizing the tooling and such).

> Somehow the vscode go plugin insists on re-organizing the imports, too. I'm not familiar enough with go and its ecosystem to understand what's going on there. That's fine - it is a best-practice to do this which I've yet to add a linter for in the pipeline (I plan on doing this while reorganizing the tooling and such).

konrad added 1 commit 2020-09-27 18:32:16 +00:00