vikunja
/
vikunja
6
43
Fork 70
Code Issues 150 Pull Requests 10 Packages Releases 32 Activity

Testing improvements #666

Merged
konrad merged 18 commits from feature/test-assert-db into master 2020-09-27 15:45:17 +00:00
Conversation 0 Commits 18 Files Changed 16 +492 -165
konrad commented 2020-09-27 14:43:52 +00:00
Owner
Copy Link

Description

This PR improves the existing tests by adding more assertions to check if some added/updated/deleted entity actually exists in the db instead of only asserting no error was returned.

Checklist

  • I added or improved tests
# Description This PR improves the existing tests by adding more assertions to check if some added/updated/deleted entity actually exists in the db instead of only asserting no error was returned. # Checklist * [x] I added or improved tests
konrad added 13 commits 2020-09-27 14:43:53 +00:00
0ca92144f2
Assert kanban tests exist in db 
Signed-off-by: kolaente <k@knt.li>
b43b666608
Assert label task tests exist in db 
Signed-off-by: kolaente <k@knt.li>
659045e351
Assert label task tests exist in db 
Signed-off-by: kolaente <k@knt.li>
2e55c48ece
Assert label tests exist in db 
Signed-off-by: kolaente <k@knt.li>
38968d4ffc
Better team list tests 
Signed-off-by: kolaente <k@knt.li>
588b538fb8
Assert exists in list tests 
Signed-off-by: kolaente <k@knt.li>
64f9c922e4
Assert exists in user list testsi 
Signed-off-by: kolaente <k@knt.li>
7cabf126b0
Assert exists in namespace tests 
Signed-off-by: kolaente <k@knt.li>
a085585012
Assert exists in namespace users tests 
Signed-off-by: kolaente <k@knt.li>
c3517589eb
Better tests for team namespaces 
Signed-off-by: kolaente <k@knt.li>
cfadc0a784
Assert task comment test exists 
Signed-off-by: kolaente <k@knt.li>
5330a96ce4
Assert task relation test exists 
Signed-off-by: kolaente <k@knt.li>
continuous-integration/drone/pr Build is failing Details
ed92a84cfb
Assert task test exists 
Signed-off-by: kolaente <k@knt.li>
konrad added 1 commit 2020-09-27 14:48:51 +00:00
continuous-integration/drone/pr Build is failing Details
4c8d0353ae
Assert team member test exists 
Signed-off-by: kolaente <k@knt.li>
konrad added 1 commit 2020-09-27 14:51:30 +00:00
continuous-integration/drone/pr Build is failing Details
b919c99704
Assert team test exists 
Signed-off-by: kolaente <k@knt.li>
konrad added 1 commit 2020-09-27 14:52:51 +00:00
continuous-integration/drone/pr Build is failing Details
e2c3ff4df8 Merge branch 'master' into feature/test-assert-db
konrad added 2 commits 2020-09-27 14:54:03 +00:00
55a670dbe2
Change method names to avoid doubling db 
Signed-off-by: kolaente <k@knt.li>
konrad merged commit 64d125afd9 into master 2020-09-27 15:45:17 +00:00
konrad referenced this issue from a commit 2020-09-27 15:45:17 +00:00
Testing improvements (#666)
konrad deleted branch feature/test-assert-db 2020-09-27 15:45:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#666
No description provided.
Delete Branch "feature/test-assert-db"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?