Add support of Unix socket #912

Merged
konrad merged 1 commits from andreymal/api:main into main 12 months ago

This may probably resolve #872, but the limitation is that this implementation doesn't allow both unix and tcp, not sure if @Dave will be happy with this

This may probably resolve #872, but the limitation is that this implementation doesn't allow both unix and tcp, not sure if @Dave will be happy with this
andreymal added 1 commit 12 months ago
2bba00d132
Add support of Unix socket
andreymal force-pushed main from 2bba00d132 to d3b79548c1 12 months ago

I'm perfectly ok with that, first of all because you provided the code :D and secondly because the entire point of a unix domain socket is to avoid the TCP/IP stack in the first place. See this:

https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets

and look at Peter Green's decently formed answer to this question.

Thank you for this code.

I'm perfectly ok with that, first of all because you provided the code :D and secondly because the entire point of a unix domain socket is to avoid the TCP/IP stack in the first place. See this: https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets and look at Peter Green's decently formed answer to this question. Thank you for this code.
konrad approved these changes 12 months ago
konrad left a comment
Owner

Looks great!

I think we can merge this once the CI passes.

Thanks for the PR.

Looks great! I think we can merge this once the CI passes. Thanks for the PR.
Owner

Ah, looks like the CI passed but not in the commit from before. I'll merge this now.

Ah, looks like the CI passed but not in the commit from before. I'll merge this now.
konrad merged commit 50b49ffab6 into main 12 months ago
konrad referenced this issue from a commit 12 months ago

This works as of the git pull I did today. :) Thank you.

This works as of the git pull I did today. :) Thank you.

Reviewers

konrad approved these changes 12 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 50b49ffab6.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.