vikunja
/
vikunja
6
43
Fork 70
Code Issues 150 Pull Requests 13 Packages Releases 32 Activity

Ensure case insensitive search on postgres #927

Merged
konrad merged 5 commits from feature/search into main 2021-08-01 21:40:27 +00:00
Conversation 0 Commits 5 Files Changed 23 +308 -108
konrad commented 2021-07-30 15:48:07 +00:00
Owner
Copy Link

Description

This PR makes ensures an ILIKE query when using postgres to always ignore the casing when searching.

Checklist

  • I added or improved tests
  • Move the conditional LIKE vs ILIKE to a new helper function since XORM doesn't have one
  • More Tests for search
# Description This PR makes ensures an `ILIKE` query when using postgres to always ignore the casing when searching. # Checklist * [x] I added or improved tests * [x] Move the conditional `LIKE` vs `ILIKE` to a new helper function since XORM doesn't have one * [x] More Tests for search
konrad added 1 commit 2021-07-30 15:48:08 +00:00
continuous-integration/drone/pr Build is failing Details
d0bde0cfd3
Add ILIKE for every LIKE query
konrad added 1 commit 2021-07-30 15:51:17 +00:00
continuous-integration/drone/pr Build is failing Details
549a87856e
Add ILIKE helper function
konrad added 1 commit 2021-07-30 21:49:58 +00:00
continuous-integration/drone/pr Build is failing Details
bdf34e50aa
Use ILIKE helper function
konrad added 1 commit 2021-07-30 22:20:44 +00:00
continuous-integration/drone/pr Build is failing Details
c6206d1c60
Add more tests for search
konrad added 1 commit 2021-08-01 21:22:02 +00:00
continuous-integration/drone/pr Build is passing Details
d91e397f88
Fix setting ILIKE column
konrad merged commit 4c5f457313 into main 2021-08-01 21:40:27 +00:00
konrad deleted branch feature/search 2021-08-01 21:40:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#927
No description provided.
Delete Branch "feature/search"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?