Added formatting check to makefile and ci #17

konrad · 2018-10-08T14:37:49Z

konrad commented

Fixes #16

konrad added this to the 0.1 milestone 2018-10-08 14:37:49 +00:00

JonasFranz was assigned by konrad

2018-10-08 14:37:49 +00:00

konrad added the

labels 2018-10-08 14:38:29 +00:00

JonasFranz commented

@konrad Maybe we could use flutter format -n lib instead because it won't make any actual changes and just lists the unformatted files.

@konrad Maybe we could use `flutter format -n lib` instead because it won't make any actual changes and just lists the unformatted files.

JonasFranz commented

Maybe use something like:

if [[ $(flutter format -n lib) ]]; then
    echo "Please run 'make format' and commit the result";
    exit 1;
fi

Maybe use something like: ```sh if [[ $(flutter format -n lib) ]]; then echo "Please run 'make format' and commit the result"; exit 1; fi ```

konrad commented

Fixed.

JonasFranz closed this pull request

konrad deleted branch feature/16-code-format

2018-10-17 08:24:38 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/app#17