Fixed app not working with the newest api change which has multiple reminders #19

Merged
konrad merged 3 commits from fix/latest-api-reminder-dates into master 2018-12-03 21:26:01 +00:00
Owner
No description provided.
JonasFranz was assigned by konrad 2018-12-02 16:03:44 +00:00
JonasFranz requested changes 2018-12-03 09:54:17 +00:00
@ -35,3 +36,3 @@
'updated': updated?.millisecondsSinceEpoch,
'created': created?.millisecondsSinceEpoch,
'reminderDate': reminder?.millisecondsSinceEpoch,
'reminderDates': reminders?.toList(),
Collaborator

The reminders should be transfered into an unix timestamp.

Use something like that:

reminders?.map((date) => date.millisecondsSinceEpoch)?.toList()
The reminders should be transfered into an unix timestamp. Use something like that: ```dart reminders?.map((date) => date.millisecondsSinceEpoch)?.toList() ```
Author
Owner

Fixed.

Fixed.
@ -82,1 +83,4 @@
}
List<DateTime> makeDateTimesFromJSON(List<dynamic> json) {
Collaborator

simply use the map function:

json?.map((milli) => DateTime.fromMillisecondsSinceEpoch(milli))?.toList()
simply use the map function: ```dart json?.map((milli) => DateTime.fromMillisecondsSinceEpoch(milli))?.toList() ```
@ -14,6 +14,7 @@ dependencies:
# Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.2
flutter_secure_storage: 3.1.1
http: 0.12.0
Collaborator

Why do you add this dependency?

Why do you add this dependency?
Author
Owner

Because the build would otherwise fail. Apparantly this was changed in the latest flutter version.

Because the build would otherwise fail. Apparantly this was changed in the latest flutter version.
Collaborator

Fair enough

Fair enough
JonasFranz added the
Type: Enhancement
Status: Revision Needed
labels 2018-12-03 09:55:09 +00:00
JonasFranz added this to the 0.1 milestone 2018-12-03 09:55:16 +00:00
konrad added
Status: Review Needed
and removed
Status: Revision Needed
labels 2018-12-03 20:44:52 +00:00
JonasFranz approved these changes 2018-12-03 20:46:50 +00:00
JonasFranz left a comment
Collaborator

CI failed, please fix! Otherwise LGTM

CI failed, please fix! Otherwise LGTM
Collaborator

CI failed, please fix.

CI failed, please fix.
JonasFranz added
Status: Revision Needed
and removed
Status: Review Needed
labels 2018-12-03 20:47:20 +00:00
Author
Owner

CI fixed

CI fixed
konrad closed this pull request 2018-12-03 21:26:01 +00:00
konrad deleted branch fix/latest-api-reminder-dates 2018-12-03 21:26:09 +00:00
JonasFranz added
Status: Completed
and removed
Status: Revision Needed
labels 2018-12-03 21:27:56 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.