List edit #21
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/app#21
Loading…
Reference in New Issue
No description provided.
Delete Branch "feature/task-edit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task editto List edit@ -48,2 +48,3 @@
: Text(_currentTask.description),
trailing: IconButton(icon: Icon(Icons.settings), onPressed: null),
trailing: IconButton(icon: Icon(Icons.settings), onPressed: () {
print("test");
Unrelated change
@ -0,0 +35,4 @@
"title": this.title,
"description": this.description,
"owner": this.owner?.toJSON(),
"created": this.created?.millisecondsSinceEpoch,
Wrong indention, make format
@ -0,0 +116,4 @@
)
);
}); // TODO: show the user a message the list was updated successfully
} catch(err) {
catch won't work here. You should use .catch instead
If I do this, is the whole
try
catch
block still nessecary?No, it's not since the that stuff is asynchron and will finish after the function already returned.
Done.
Please run
make format
Done.
@ -0,0 +92,4 @@
_saveList(BuildContext context) async {
setState(() => _loading = true);
// FIXME: is there a way we can update the list without creating a new list object?
// aka updating the existing list we got from context (setters?)
That's not possible. You may add a function like copyWith(...) as helper. But this may be to big for the problem.
I see, thanks!
I see, thanks!