List edit #21

Merged
JonasFranz merged 8 commits from feature/task-edit into master 2019-03-11 20:29:16 +00:00
Owner
No description provided.
konrad changed title from Task edit to List edit 2019-03-08 21:24:30 +00:00
JonasFranz was assigned by konrad 2019-03-10 12:49:01 +00:00
JonasFranz requested changes 2019-03-10 17:54:05 +00:00
@ -48,2 +48,3 @@
: Text(_currentTask.description),
trailing: IconButton(icon: Icon(Icons.settings), onPressed: null),
trailing: IconButton(icon: Icon(Icons.settings), onPressed: () {
print("test");
Collaborator

Unrelated change

Unrelated change
@ -0,0 +35,4 @@
"title": this.title,
"description": this.description,
"owner": this.owner?.toJSON(),
"created": this.created?.millisecondsSinceEpoch,
Collaborator

Wrong indention, make format

Wrong indention, make format
@ -0,0 +116,4 @@
)
);
}); // TODO: show the user a message the list was updated successfully
} catch(err) {
Collaborator

catch won't work here. You should use .catch instead

catch won't work here. You should use .catch instead
Author
Owner

If I do this, is the whole try catch block still nessecary?

If I do this, is the whole `try` `catch` block still nessecary?
Collaborator

No, it's not since the that stuff is asynchron and will finish after the function already returned.

No, it's not since the that stuff is asynchron and will finish after the function already returned.
Author
Owner

Done.

Done.
Collaborator

Please run make format

Please run `make format`
Author
Owner

Done.

Done.
JonasFranz approved these changes 2019-03-11 20:28:14 +00:00
@ -0,0 +92,4 @@
_saveList(BuildContext context) async {
setState(() => _loading = true);
// FIXME: is there a way we can update the list without creating a new list object?
// aka updating the existing list we got from context (setters?)
Collaborator

That's not possible. You may add a function like copyWith(...) as helper. But this may be to big for the problem.

That's not possible. You may add a function like copyWith(...) as helper. But this may be to big for the problem.
Author
Owner

I see, thanks!

I see, thanks!
Author
Owner

I see, thanks!

I see, thanks!
JonasFranz added the
Type: Enhancement
Status: Completed
labels 2019-03-11 20:29:00 +00:00
JonasFranz closed this pull request 2019-03-11 20:29:16 +00:00
JonasFranz deleted branch feature/task-edit 2019-03-11 20:29:22 +00:00
konrad referenced this issue from a commit 2019-03-11 20:34:35 +00:00
konrad added this to the 0.1 milestone 2019-03-16 15:41:41 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.