vikunja
/
app
Archived
6
1
Fork 1
Code Issues 4 Pull Requests 11 Releases Wiki Activity

Fixed app not working with the newest api change which has multiple reminders #19

Merged
konrad merged 3 commits from fix/latest-api-reminder-dates into master 2018-12-03 21:26:01 +00:00
Conversation 2 Commits 3 Files Changed 2 +20 -4
2 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0751ab1695 - Show all commits

23
lib/models/task.dart
View File

@ -3,7 +3,8 @@ import 'package:meta/meta.dart';
class Task {
final int id;
final DateTime created, updated, reminder, due;
final DateTime created, updated, due;
final List<DateTime> reminders;
final String text, description;
final bool done;
final User owner;
@ -12,7 +13,7 @@ class Task {
{@required this.id,
this.created,
this.updated,
this.reminder,
this.reminders,
this.due,
@required this.text,
this.description,
@ -23,7 +24,7 @@ class Task {
: id = json['id'],
updated = DateTime.fromMillisecondsSinceEpoch(json['updated']),
created = DateTime.fromMillisecondsSinceEpoch(json['created']),
reminder = DateTime.fromMillisecondsSinceEpoch(json['reminderDate']),
reminders = makeDateTimesFromJSON(json['reminderDates'] as List<dynamic>),
due = DateTime.fromMillisecondsSinceEpoch(json['dueDate']),
description = json['description'],
text = json['text'],
@ -34,7 +35,7 @@ class Task {
'id': id,
'updated': updated?.millisecondsSinceEpoch,
'created': created?.millisecondsSinceEpoch,
'reminderDate': reminder?.millisecondsSinceEpoch,
'reminderDates': reminders?.toList(),
JonasFranz commented 2018-12-03 09:52:43 +00:00
Outdated
Review
Copy Link

The reminders should be transfered into an unix timestamp.

Use something like that:

reminders?.map((date) => date.millisecondsSinceEpoch)?.toList()
The reminders should be transfered into an unix timestamp. Use something like that: ```dart reminders?.map((date) => date.millisecondsSinceEpoch)?.toList() ```
konrad commented 2018-12-03 12:52:22 +00:00
Outdated
Review
Copy Link

Fixed.

Fixed.
'dueDate': due?.millisecondsSinceEpoch,
'description': description,
'text': text,
@ -80,3 +81,17 @@ class TaskList {
};
}
}
List<DateTime> makeDateTimesFromJSON(List<dynamic> json) {
JonasFranz commented 2018-12-03 09:53:56 +00:00
Outdated
Review
Copy Link

simply use the map function:

json?.map((milli) => DateTime.fromMillisecondsSinceEpoch(milli))?.toList()
simply use the map function: ```dart json?.map((milli) => DateTime.fromMillisecondsSinceEpoch(milli))?.toList() ```
List<DateTime> dates = new List<DateTime>();
if(json == null) {
return dates;
}
for(var i = 0; i < json.length; i++) {
dates.add(DateTime.fromMillisecondsSinceEpoch(json[i]));
}
return dates;
}

1
pubspec.yaml
View File

@ -14,6 +14,7 @@ dependencies:
# Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.2
flutter_secure_storage: 3.1.1
http: 0.12.0
JonasFranz commented 2018-12-03 09:54:12 +00:00
Review
Copy Link

Why do you add this dependency?

Why do you add this dependency?
konrad commented 2018-12-03 12:53:23 +00:00
Review
Copy Link

Because the build would otherwise fail. Apparantly this was changed in the latest flutter version.

Because the build would otherwise fail. Apparantly this was changed in the latest flutter version.
JonasFranz commented 2018-12-03 15:47:52 +00:00
Review
Copy Link

Fair enough

Fair enough
dev_dependencies:
flutter_test: