vikunja
/
app
Archived
6
1
Fork 1
Code Issues 4 Pull Requests 11 Releases Wiki Activity

Fixed app not working with the newest api change which has multiple reminders #19

Merged
konrad merged 3 commits from fix/latest-api-reminder-dates into master 2018-12-03 21:26:01 +00:00
Conversation 2 Commits 3 Files Changed 2 +2 -16
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8b1f0da773 - Show all commits

18
lib/models/task.dart
View File

@ -24,7 +24,7 @@ class Task {
: id = json['id'],
updated = DateTime.fromMillisecondsSinceEpoch(json['updated']),
created = DateTime.fromMillisecondsSinceEpoch(json['created']),
reminders = makeDateTimesFromJSON(json['reminderDates'] as List<dynamic>),
reminders = (json['reminderDates'] as List<dynamic>)?.map((milli) => DateTime.fromMillisecondsSinceEpoch(milli))?.toList(),
due = DateTime.fromMillisecondsSinceEpoch(json['dueDate']),
description = json['description'],
text = json['text'],
@ -35,7 +35,7 @@ class Task {
'id': id,
'updated': updated?.millisecondsSinceEpoch,
'created': created?.millisecondsSinceEpoch,
'reminderDates': reminders?.toList(),
'reminderDates': reminders?.map((date) => date.millisecondsSinceEpoch)?.toList(),
JonasFranz commented 2018-12-03 09:52:43 +00:00
Outdated
Review
Copy Link

The reminders should be transfered into an unix timestamp.

Use something like that:

reminders?.map((date) => date.millisecondsSinceEpoch)?.toList()
The reminders should be transfered into an unix timestamp. Use something like that: ```dart reminders?.map((date) => date.millisecondsSinceEpoch)?.toList() ```
konrad commented 2018-12-03 12:52:22 +00:00
Outdated
Review
Copy Link

Fixed.

Fixed.
'dueDate': due?.millisecondsSinceEpoch,
'description': description,
'text': text,
@ -81,17 +81,3 @@ class TaskList {
};
}
}
List<DateTime> makeDateTimesFromJSON(List<dynamic> json) {
List<DateTime> dates = new List<DateTime>();
if(json == null) {
return dates;
}
for(var i = 0; i < json.length; i++) {
dates.add(DateTime.fromMillisecondsSinceEpoch(json[i]));
}
return dates;
}