Task edit #37

Open
konrad wants to merge 76 commits from feature/edit-task into master
Owner
No description provided.
konrad added this to the 0.1 milestone 2019-03-19 19:53:08 +00:00
JonasFranz was assigned by konrad 2019-03-19 19:53:08 +00:00
konrad changed title from WIP: Task edit to Task edit 2019-03-23 17:38:27 +00:00
Author
Owner

@JonasFranz Please review

@JonasFranz Please review
Author
Owner

@JonasFranz please review

@JonasFranz please review
konrad added the
Status: Ready for Review
label 2019-03-30 12:17:35 +00:00
JonasFranz requested changes 2019-04-02 08:29:11 +00:00
@ -0,0 +21,4 @@
@override
Future<List<Label>> getAll(LabelTask lt, {String query}) async {
String params = query == '' ? null : '?s=' + query;
Collaborator

query is not url encoded => security = dead

query is not url encoded => security = dead
Author
Owner

Fixed.

Fixed.
@ -0,0 +25,4 @@
@override
Future<List<Label>> getAll({String query}) {
String params = query == '' ? null : '?s=' + query;
Collaborator

same

same
@ -0,0 +36,4 @@
'description': description,
'hex_color': color?.value == null
? null
: color.value.toRadixString(16).padLeft(8, '0').substring(2),
Collaborator

Please use

color?.value?.toRadixString(16)?.padLeft(8, '0')?.substring(2)

instead.

Please use ```dart color?.value?.toRadixString(16)?.padLeft(8, '0')?.substring(2) ``` instead.
@ -5,3 +8,1 @@
final int id;
final DateTime created, updated, due;
final List<DateTime> reminders;
final int id, parentTaskID, priority;
Collaborator

parentTaskID => parentTaskId

`parentTaskID` => `parentTaskId`
@ -63,2 +60,3 @@
: Center(child: Text('This list is empty.')),
onRefresh: _loadList,
child: /*_list.tasks.length > 0
? */
Collaborator

Remove unused comments

Remove unused comments
@ -65,0 +65,4 @@
children: ListTile.divideTiles(context: context, tiles: tasks)
.toList(),
),
//: Center(child: Text('This list is empty.')),
Collaborator

same

same
@ -67,3 +71,3 @@
floatingActionButton: Builder(
builder: (context) => FloatingActionButton(
onPressed: () => _addItemDialog(context), child: Icon(Icons.add)),
//onPressed: () => _addItemDialog(context), child: Icon(Icons.add)),
Collaborator

same

same
Author
Owner

Done.

Done.
JonasFranz added
Status: Revision Needed
and removed
Status: Ready for Review
labels 2019-04-02 08:31:13 +00:00
konrad added
Status: Ready for Review
and removed
Status: Revision Needed
labels 2019-04-02 09:12:22 +00:00
JonasFranz requested changes 2019-04-10 07:33:10 +00:00
JonasFranz left a comment
Collaborator

Reminders should be removable although they have no date time.

Reminders should be removable although they have no date time.
JonasFranz added
Status: Revision Needed
and removed
Status: Ready for Review
labels 2019-04-10 07:33:23 +00:00
Collaborator

Conflicted

Conflicted
This repo is archived. You cannot comment on pull requests.
No description provided.