Task edit #37
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/app#37
Loading…
Reference in New Issue
No description provided.
Delete Branch "feature/edit-task"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WIP: Task editto Task edit@JonasFranz Please review
@JonasFranz please review
@ -0,0 +21,4 @@
@override
Future<List<Label>> getAll(LabelTask lt, {String query}) async {
String params = query == '' ? null : '?s=' + query;
query is not url encoded => security = dead
Fixed.
@ -0,0 +25,4 @@
@override
Future<List<Label>> getAll({String query}) {
String params = query == '' ? null : '?s=' + query;
same
@ -0,0 +36,4 @@
'description': description,
'hex_color': color?.value == null
? null
: color.value.toRadixString(16).padLeft(8, '0').substring(2),
Please use
instead.
@ -5,3 +8,1 @@
final int id;
final DateTime created, updated, due;
final List<DateTime> reminders;
final int id, parentTaskID, priority;
parentTaskID
=>parentTaskId
@ -63,2 +60,3 @@
: Center(child: Text('This list is empty.')),
onRefresh: _loadList,
child: /*_list.tasks.length > 0
? */
Remove unused comments
@ -65,0 +65,4 @@
children: ListTile.divideTiles(context: context, tiles: tasks)
.toList(),
),
//: Center(child: Text('This list is empty.')),
same
@ -67,3 +71,3 @@
floatingActionButton: Builder(
builder: (context) => FloatingActionButton(
onPressed: () => _addItemDialog(context), child: Icon(Icons.add)),
//onPressed: () => _addItemDialog(context), child: Icon(Icons.add)),
same
Done.
Reminders should be removable although they have no date time.
Conflicted