Re-implemented getting tasks with the new seperate endpoint #39
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/app#39
Loading…
Reference in New Issue
No description provided.
Delete Branch "feature/task-list"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
TODO
Needs a good way to hanlde query parameters in the services
An interesting side-effect: When scrolling slowly, it works as expected. When scrolling fast, it only loads the first 50 items and throws an error.
Also, the scrolling is kind of buggy, as in not 60fps. More like 10.
Loading seems to work now.
Looks like it is trying to load the next page until the end of time. (I stopped it at 704)
I found all service implementations are using the same http client (which makes sense) but because the max number of pages is saved in the client in the
_maxPages
attribute, when there is a request by a completly different service in between the loading of two pages of data,_maxPages
gets overridden.It looks like the list with all namespaces is loaded between the first and the second page of tasks.
maxPages
is zero?I've added a workaround for loading a page, it seems to be working now.
The third one needs to be fixed though.
The first one maybe not in this pr.
WIP: Re-implemented getting tasks with the new seperate endpointto Re-implemented getting tasks with the new seperate endpoint@ -63,0 +77,4 @@
task: taskState.tasks[index],
)
: null;
})
Please create a custom widget which handles auto loading new tasks and inserting dividers.
@ -109,13 +110,14 @@ class _ListPageState extends State<ListPage> {
}
_addItem(String name, BuildContext context) {
// FIXME: Use provider
resolve provider
Done.
@ -104,0 +108,4 @@
child: ListPage(
taskList: list,
),
),
Maybe init the provider in the ListPage? Make sure to use Builder as child when doing it.
You mean in the
build
method of it?@ -68,0 +87,4 @@
// are not using pagination.
if (response.headers["x-pagination-total-pages"] != null) {
_maxPages = int.parse(response.headers["x-pagination-total-pages"]);
}
Please save this in stores. This shouldn't be handled by the client.
Done!
Related: #50