Add sentry #43

JonasFranz · 2020-06-17T15:03:54Z

JonasFranz commented

2020-06-17 15:03:54 +00:00

No description provided.

konrad reviewed 2020-06-17 15:06:36 +00:00

lib/main.dart

						
				@ -9,1 +11,3 @@

				    login: new VikunjaApp(home: LoginPage())));

				void main() {

				  var sentry = new SentryClient(

				      dsn: "https://ab786a1feac7418d87187465b6f30ee0@sentry.k8s.jfdev.de/2");

konrad commented

2020-06-17 15:06:36 +00:00

This should not be hardcoded.

JonasFranz commented

2020-06-17 15:18:22 +00:00

Fixed

JonasFranz marked this conversation as resolved

JonasFranz changed title from ~~WIP: Add sentry~~ to Add sentry

2020-06-17 15:15:43 +00:00

JonasFranz requested review from konrad 2020-06-17 15:18:36 +00:00

JonasFranz added the

Type: Enhancement

label 2020-06-17 15:18:56 +00:00

JonasFranz added this to the 0.1 milestone 2020-06-17 15:18:59 +00:00

JonasFranz added the

Status: Ready for Review

label 2020-06-17 15:19:41 +00:00

konrad approved these changes 2020-06-17 15:37:29 +00:00

konrad referenced this issue from a commit

2020-06-17 15:37:42 +00:00

Add sentry (#43) Refactor DSN to constants Use correct import Add sentry Co-authored-by: Jonas Franz <info@jonasfranz.software> Reviewed-on: https://kolaente.dev/vikunja/app/pulls/43 Reviewed-by: konrad <konrad@kola-entertainments.de>

konrad merged commit 9c2622e77f into master

2020-06-17 15:37:43 +00:00

JonasFranz deleted branch feature/sentry

2020-06-17 15:37:53 +00:00

konrad referenced this issue from a commit

2020-07-10 08:35:14 +00:00

Revert "Add sentry (#43)"

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/app#43