Desktop app opens links in popup, probably because of a change in Electron 22 #130

New Issue

hkockerbeck · 2022-12-21T15:18:41Z

hkockerbeck commented

2022-12-21 15:18:41 +00:00

Texts in Vikunja, like the description of a task, can contain links. For example, a task could have a description like

Work through the tutorial at [some site](https://some.site.tld).

Up until version 0.20.1, clicking on such a link openend the corresponding url in the system browser. I'd assume that to be the intended behaviour.

Since version 0.20.2, clicking on such a link opens the corresponding url inside Vikunja in a popup.

I've looked into this very cursory, and my hunch would be that the cause is a change in Electron 22, which the desktop app uses since v0.20.2:

The deprecated new-window event has been removed. #34526

When I start the Vikunja 0.20.1 AppImage from the command line and click on a link as described above, I get the output

(electron) The new-window event is deprecated and will be removed. Please use contents.setWindowOpenHandler() instead.

This note doesn't appear when I try the same with the 0.20.2 AppImage.

Texts in Vikunja, like the description of a task, can contain links. For example, a task could have a description like Work through the tutorial at [some site](https://some.site.tld). Up until version 0.20.1, clicking on such a link openend the corresponding url in the system browser. I'd assume that to be the intended behaviour. Since version 0.20.2, clicking on such a link opens the corresponding url inside Vikunja in a popup. I've looked into this very cursory, and my hunch would be that the cause is [a change in Electron 22](https://releases.electronjs.org/release/v22.0.0), which the desktop app uses since v0.20.2: > The deprecated new-window event has been removed. [#34526](https://github.com/electron/electron/pull/34526) When I start the Vikunja 0.20.1 AppImage from the command line and click on a link as described above, I get the output > (electron) The new-window event is deprecated and will be removed. Please use contents.setWindowOpenHandler() instead. This note doesn't appear when I try the same with the 0.20.2 AppImage.

konrad added the

bug

label 2022-12-23 18:02:35 +00:00

konrad referenced this issue from a commit

2022-12-23 18:05:15 +00:00

fix: open links in OS default browser

konrad closed this issue

2022-12-23 18:05:15 +00:00

konrad commented

2022-12-23 18:06:02 +00:00

Fixed in 99153187d7 - please check with the next unstable build (ready in ~20 min) if the issue went away.

Fixed in https://kolaente.dev/vikunja/desktop/commit/99153187d77d5b2311bc2a87864f70b9d2563370 - please check with the next unstable build (ready in ~20 min) if the issue went away.

hkockerbeck commented

2023-01-15 15:32:35 +00:00

Sorry for the late response. I can confirm that the problem doesn't occur in the latest unstable build anymore. Thanks for the fix :)

This repo is archived. You cannot comment on issues.